From 9f42aff3b589e9a50d3a33e5da1a1be87042be7b Mon Sep 17 00:00:00 2001 From: Luke Kenneth Casson Leighton Date: Sun, 21 Apr 2019 08:26:07 +0100 Subject: [PATCH] comment where PermissionValidator needed --- TLB/src/ariane/mmu.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/TLB/src/ariane/mmu.py b/TLB/src/ariane/mmu.py index 0cc04dbb..a5c27a9e 100644 --- a/TLB/src/ariane/mmu.py +++ b/TLB/src/ariane/mmu.py @@ -231,10 +231,12 @@ class MMU: m.d.comb += icache_areq_o.fetch_exception.eq(0) # Check whether we are allowed to access this memory region # from a fetch perspective + + # XXX TODO: use PermissionValidator instead [we like modules] m.d.comb += iaccess_err.eq(icache_areq_i.fetch_req & \ (((priv_lvl_i == PRIV_LVL_U) & \ ~itlb_content.u) | \ - ((priv_lvl_i == :PRIV_LVL_S) & \ + ((priv_lvl_i == PRIV_LVL_S) & \ itlb_content.u))) # MMU enabled: address from TLB, request delayed until hit. -- 2.30.2