From 9f6a71b4bfdad8fa2fe33e86f799fa0d362973dc Mon Sep 17 00:00:00 2001 From: Yao Qi Date: Wed, 10 Feb 2016 16:40:52 +0000 Subject: [PATCH] Clear *VAL in regcache_raw_read_unsigned We have function regcache_raw_read_unsigned defined in both GDB and GDBserver, so that it is used in common like this, ULONGEST value; status = regcache_raw_read_unsigned (regcache, regnum, &value); 'value' is correctly set in GDB side, but may not be correctly set in GDBserver, because &value is passed in regcache_raw_read_unsigned but collect_register may only set part of the whole variable. In my test, I see the top half of 'value' is garbage. This patch fixes this problem by clearing *VAL before calling collect_register. gdb/gdbserver: 2016-02-10 Yao Qi * regcache.c (regcache_raw_read_unsigned): Clear *VAL. --- gdb/gdbserver/ChangeLog | 4 ++++ gdb/gdbserver/regcache.c | 1 + 2 files changed, 5 insertions(+) diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index 30df0bc8a83..2c11f89730f 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,7 @@ +2016-02-10 Yao Qi + + * regcache.c (regcache_raw_read_unsigned): Clear *VAL. + 2016-02-09 Simon Marchi * configure.ac: Use AC_CONFIG_FILES instead of passing arguments diff --git a/gdb/gdbserver/regcache.c b/gdb/gdbserver/regcache.c index 6a737ea37ec..2af8e241d98 100644 --- a/gdb/gdbserver/regcache.c +++ b/gdb/gdbserver/regcache.c @@ -440,6 +440,7 @@ regcache_raw_read_unsigned (struct regcache *regcache, int regnum, "%d bytes."), (int) sizeof (ULONGEST)); + *val = 0; collect_register (regcache, regnum, val); return REG_VALID; -- 2.30.2