From 9f7fb0aa2b6eb9fb185c1c2ae4159d783acadc0e Mon Sep 17 00:00:00 2001 From: Alan Hayward Date: Tue, 6 Jun 2017 16:34:20 +0100 Subject: [PATCH] Remove a MAX_REGISTER_SIZE from frame.c gdb/ * frame.c (frame_unwind_register_signed): Use frame_unwind_register_value. --- gdb/ChangeLog | 5 +++++ gdb/frame.c | 23 ++++++++++++++++++++--- 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 00731226acd..27e56c368d7 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2017-06-06 Alan Hayward + + * frame.c (frame_unwind_register_signed): Use + frame_unwind_register_value. + 2017-06-06 Pedro Alves PR breakpoints/21553 diff --git a/gdb/frame.c b/gdb/frame.c index efe5a20591d..30e4aeab7e2 100644 --- a/gdb/frame.c +++ b/gdb/frame.c @@ -1252,10 +1252,27 @@ frame_unwind_register_signed (struct frame_info *frame, int regnum) struct gdbarch *gdbarch = frame_unwind_arch (frame); enum bfd_endian byte_order = gdbarch_byte_order (gdbarch); int size = register_size (gdbarch, regnum); - gdb_byte buf[MAX_REGISTER_SIZE]; + struct value *value = frame_unwind_register_value (frame, regnum); + + gdb_assert (value != NULL); + + if (value_optimized_out (value)) + { + throw_error (OPTIMIZED_OUT_ERROR, + _("Register %d was not saved"), regnum); + } + if (!value_entirely_available (value)) + { + throw_error (NOT_AVAILABLE_ERROR, + _("Register %d is not available"), regnum); + } - frame_unwind_register (frame, regnum, buf); - return extract_signed_integer (buf, size, byte_order); + LONGEST r = extract_signed_integer (value_contents_all (value), size, + byte_order); + + release_value (value); + value_free (value); + return r; } LONGEST -- 2.30.2