From a0dad1b071e61b707744552c7fbf266dd8deb447 Mon Sep 17 00:00:00 2001 From: Gabriel Somlo Date: Thu, 12 Dec 2019 09:02:47 -0500 Subject: [PATCH] soc_core: additional CSR safety assertions Since csr_data_width=64 has probably never worked properly, remove it as one of the possible options (to be fixed and re-added later). Add csr_data_width=16, which has been tested and does work. Additionally, ensure csr_data_width <= csr_alignment (we should not attempt to create (sub)registers larger than the CPU's native word size or XLen). Signed-off-by: Gabriel Somlo --- litex/soc/integration/soc_core.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/litex/soc/integration/soc_core.py b/litex/soc/integration/soc_core.py index ca670ff0..63c1f8ef 100644 --- a/litex/soc/integration/soc_core.py +++ b/litex/soc/integration/soc_core.py @@ -137,7 +137,7 @@ class SoCCore(Module): self.integrated_sram_size = integrated_sram_size self.integrated_main_ram_size = integrated_main_ram_size - assert csr_data_width in [8, 32, 64] + assert csr_data_width in [8, 16, 32] self.csr_data_width = csr_data_width self.csr_address_width = csr_address_width @@ -257,6 +257,7 @@ class SoCCore(Module): csr_alignment = max(csr_alignment, self.cpu.data_width) self.config["CSR_DATA_WIDTH"] = csr_data_width self.config["CSR_ALIGNMENT"] = csr_alignment + assert csr_data_width <= csr_alignment self.csr_data_width = csr_data_width self.csr_alignment = csr_alignment if with_wishbone: -- 2.30.2