From a1fc6a91e5c6ab098fa8576e63b3a070852aa2a7 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Jos=C3=A9=20Fonseca?= Date: Tue, 2 Dec 2014 20:20:43 +0000 Subject: [PATCH] mesa: Ensure stack is realigned on x86. Nowadays GCC assumes stack pointer is 16-byte aligned even on 32-bits, but that is an assumption OpenGL drivers (or any dynamic library for that matter) can't afford to make as there are many closed- and open- source application binaries out there that only assume 4-byte stack alignment. This fix uses force_align_arg_pointer GCC attribute, and is only a stop-gap measure. The right fix would be to pass -mstackrealign or -mincoming-stack-boundary=2 to all source fails that use any -msse* option, as there is no way to guarantee if/when GCC will decide to spill SSE registers to the stack. https://bugs.freedesktop.org/show_bug.cgi?id=86788 Reviewed-by: Brian Paul --- src/mesa/main/sse_minmax.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/main/sse_minmax.c b/src/mesa/main/sse_minmax.c index 222ac14542e..93cf2a6be30 100644 --- a/src/mesa/main/sse_minmax.c +++ b/src/mesa/main/sse_minmax.c @@ -31,6 +31,9 @@ #include void +#if !defined(__x86_64__) + __attribute__((force_align_arg_pointer)) +#endif _mesa_uint_array_min_max(const unsigned *ui_indices, unsigned *min_index, unsigned *max_index, const unsigned count) { -- 2.30.2