From a2199296ce71a44981f1d6ad7800e7742ff39dd8 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Thu, 22 May 2014 14:01:46 -0400 Subject: [PATCH] Add comment for mi_run_cmd_full It should clear up confusion about the args parameter to mi_run_cmd_full. Thanks to Joel for clear formulation. I also added a comment about the impact of use_gdb_stub. gdb/testsuite/ChangeLog: 2014-05-22 Simon Marchi * lib/mi-support.exp (mi_run_cmd_full): Add comments. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/lib/mi-support.exp | 12 ++++++++++++ 2 files changed, 16 insertions(+) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index b25e4787d5f..1473d9681b1 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2014-05-22 Simon Marchi + + * lib/mi-support.exp (mi_run_cmd_full): Add comments. + 2014-05-21 Pedro Alves PR gdb/13860 diff --git a/gdb/testsuite/lib/mi-support.exp b/gdb/testsuite/lib/mi-support.exp index 09a514b9656..9f07cdab793 100644 --- a/gdb/testsuite/lib/mi-support.exp +++ b/gdb/testsuite/lib/mi-support.exp @@ -830,6 +830,18 @@ proc mi_gdb_expect_cli_output {until message} { # In patterns, the newline sequence ``\r\n'' is matched explicitly as # ``.*$'' could swallow up output that we attempt to match elsewhere. +# Send the command to run the test program. +# +# If USE_MI_COMMAND is true, the "-exec-run" command is used. +# Otherwise, the "run" (CLI) command is used. If the global USE_GDB_STUB is +# true, -exec-continue and continue are used instead of their run counterparts. +# +# ARGS is passed as argument to the command used to run the test program. +# Beware that arguments to "-exec-run" do not have the same semantics as +# arguments to the "run" command, so USE_MI_COMMAND influences the meaning +# of ARGS. If USE_MI_COMMAND is true, they are arguments to -exec-run. +# If USE_MI_COMMAND is false, they are effectively arguments passed +# to the test program. If the global USE_GDB_STUB is true, ARGS is not used. proc mi_run_cmd_full {use_mi_command args} { global suppress_flag if { $suppress_flag } { -- 2.30.2