From a2283b50e68ffb560057e53fa195aa8498246d8c Mon Sep 17 00:00:00 2001 From: Emil Velikov Date: Mon, 21 Nov 2016 17:53:33 +0000 Subject: [PATCH] docs/submitting patches: mention get_reviewers.pl Mention the script - why/how to use alongside a useful trick to make it work interactively (thanks Rob!). Signed-off-by: Emil Velikov Reviewed-by: Elie Tournier --- docs/submittingpatches.html | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/docs/submittingpatches.html b/docs/submittingpatches.html index d2b605bf878..2d18c74decf 100644 --- a/docs/submittingpatches.html +++ b/docs/submittingpatches.html @@ -104,6 +104,19 @@ that should be documented with: Reviewed-by: Joe Hacker <jhacker@foo.com> Acked-by: Joe Hacker <jhacker@foo.com> +
  • In order for your patch to reach the prospective reviewer easier/faster, +use the script scripts/get_reviewer.pl to get a list of individuals and include +them in the CC list. +
    +Please use common sense and do not blindly add everyone. +
    +
    +    $ scripts/get_reviewer.pl --help # to get the the help screen
+    $ scripts/get_reviewer.pl -f src/egl/drivers/dri2/platform_android.c
+    Rob Herring  (reviewer:ANDROID EGL SUPPORT,added_lines:188/700=27%,removed_lines:58/283=20%)
+    Tomasz Figa  (reviewer:ANDROID EGL SUPPORT,authored:12/41=29%,added_lines:308/700=44%,removed_lines:115/283=41%)
+    Emil Velikov  (authored:13/41=32%,removed_lines:76/283=27%)
+
    @@ -335,6 +348,11 @@ commits before sending. git send-email --subject-prefix="PATCH v4" HEAD~8 git send-email -v4 @~8 # shorter version, inherited from git format-patch +
  • Configure git to use the get_reviewer.pl script interactively. Thus you +can avoid adding the world to the CC list. +
    +    git config sendemail.cccmd "./scripts/get_reviewer.pl -i"
+
    -- 2.30.2