From a2ef097954b08063f1100d45c3d8499ac9fc46f8 Mon Sep 17 00:00:00 2001 From: Andrew Pinski Date: Wed, 30 Aug 2006 04:33:10 +0000 Subject: [PATCH] re PR c++/28349 (ICE with "undefined" va_arg and references) 2006-08-29 Andrew Pinski PR c++/28349 * testsuite/g++.dg/warn/var-args1.C: New test. 2006-08-29 Andrew Pinski PR C++/28349 * call.c (build_x_va_arg): Remove the reference type from the type before creating the pointer type. From-SVN: r116577 --- gcc/cp/ChangeLog | 6 ++++++ gcc/cp/call.c | 4 +++- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/g++.dg/warn/var-args1.C | 11 +++++++++++ 4 files changed, 25 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/g++.dg/warn/var-args1.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 3774c14d33d..cda27425430 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,9 @@ +2006-08-29 Andrew Pinski + + PR C++/28349 + * call.c (build_x_va_arg): Remove the reference type + from the type before creating the pointer type. + 2006-08-29 J"orn Rennecke PR c++/28139 diff --git a/gcc/cp/call.c b/gcc/cp/call.c index a91ecd015f8..7a6646f7200 100644 --- a/gcc/cp/call.c +++ b/gcc/cp/call.c @@ -4544,10 +4544,12 @@ build_x_va_arg (tree expr, tree type) if (! pod_type_p (type)) { + /* Remove reference types so we don't ICE later on. */ + tree type1 = non_reference (type); /* Undefined behavior [expr.call] 5.2.2/7. */ warning (0, "cannot receive objects of non-POD type %q#T through %<...%>; " "call will abort at runtime", type); - expr = convert (build_pointer_type (type), null_node); + expr = convert (build_pointer_type (type1), null_node); expr = build2 (COMPOUND_EXPR, TREE_TYPE (expr), call_builtin_trap (), expr); expr = build_indirect_ref (expr, NULL); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 6729166449d..15f5d63650c 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2006-08-29 Andrew Pinski + + PR c++/28349 + * testsuite/g++.dg/warn/var-args1.C: New test. + 2006-08-29 Steven G. Kargl PR fortran/28866 diff --git a/gcc/testsuite/g++.dg/warn/var-args1.C b/gcc/testsuite/g++.dg/warn/var-args1.C new file mode 100644 index 00000000000..aadac20e84a --- /dev/null +++ b/gcc/testsuite/g++.dg/warn/var-args1.C @@ -0,0 +1,11 @@ +/* { dg-do compile } */ + +#include + +void foo(int, ...) +{ + va_list va; + int i; + i = va_arg(va, int&); /* { dg-warning "cannot receive objects" } */ +} + -- 2.30.2