From a3237c7cc7de4b3ea44d8874a0c90dff1f4d31dc Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Fri, 7 May 2021 22:14:27 +0100 Subject: [PATCH] gdb/testsuite: use gdb_test_no_output instead of send_gdb I noticed gdb.base/ptype-offsets.exp failing occasionally, this was due to lines like this in the test script: send_gdb "set print type hex on\n" As this does not match the '(gdb)' prompt that is produced, the prompt would sometimes be matched against the next test, causing the next test to think its output was missing and fail. Fix this by switching to: gdb_test_no_output "set print type hex on" gdb/testsuite/ChangeLog: * gdb.base/ptype-offsets.exp: Replace use of send_gdb with gdb_test_no_output. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.base/ptype-offsets.exp | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 3813c19ac5b..2fac86e2cea 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2021-05-07 Andrew Burgess + + * gdb.base/ptype-offsets.exp: Replace use of send_gdb with + gdb_test_no_output. + 2021-05-07 Simon Marchi * Re-format all Python files using black. diff --git a/gdb/testsuite/gdb.base/ptype-offsets.exp b/gdb/testsuite/gdb.base/ptype-offsets.exp index cc017ad7909..3f42250c07f 100644 --- a/gdb/testsuite/gdb.base/ptype-offsets.exp +++ b/gdb/testsuite/gdb.base/ptype-offsets.exp @@ -413,7 +413,7 @@ gdb_test "ptype/o empty_member" \ with_test_prefix "with_hex_default" { # Test setting default display to hex - send_gdb "set print type hex on\n" + gdb_test_no_output "set print type hex on" gdb_test "show print type hex" \ "Display of struct members offsets and sizes in hexadecimal is on" @@ -467,5 +467,5 @@ with_test_prefix "with_hex_default" { " \}"]] # restore - send_gdb "set print type hex off\n" + gdb_test_no_output "set print type hex off" } -- 2.30.2