From a3c2a86757a3ca25453b7143f1c774c5f7fe499e Mon Sep 17 00:00:00 2001 From: Samuel Pitoiset Date: Thu, 4 Jan 2018 15:19:47 +0100 Subject: [PATCH] radv: make shader BOs read-only for the GPU Signed-off-by: Samuel Pitoiset Reviewed-by: Bas Nieuwenhuizen --- src/amd/vulkan/radv_device.c | 2 ++ src/amd/vulkan/radv_private.h | 1 + src/amd/vulkan/radv_shader.c | 5 ++++- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c index 5f78af624b5..528d3539c91 100644 --- a/src/amd/vulkan/radv_device.c +++ b/src/amd/vulkan/radv_device.c @@ -263,6 +263,8 @@ radv_physical_device_init(struct radv_physical_device *device, */ device->has_clear_state = device->rad_info.chip_class >= CIK; + device->cpdma_prefetch_writes_memory = device->rad_info.chip_class <= VI; + radv_physical_device_init_mem_types(device); result = radv_init_wsi(device); diff --git a/src/amd/vulkan/radv_private.h b/src/amd/vulkan/radv_private.h index 30ccbea176a..f691c832bc2 100644 --- a/src/amd/vulkan/radv_private.h +++ b/src/amd/vulkan/radv_private.h @@ -272,6 +272,7 @@ struct radv_physical_device { bool has_rbplus; /* if RB+ register exist */ bool rbplus_allowed; /* if RB+ is allowed */ bool has_clear_state; + bool cpdma_prefetch_writes_memory; /* This is the drivers on-disk cache used as a fallback as opposed to * the pipeline cache defined by apps. diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index 31879805ae0..971d3abac91 100644 --- a/src/amd/vulkan/radv_shader.c +++ b/src/amd/vulkan/radv_shader.c @@ -330,7 +330,10 @@ radv_alloc_shader_memory(struct radv_device *device, slab->size = 256 * 1024; slab->bo = device->ws->buffer_create(device->ws, slab->size, 256, - RADEON_DOMAIN_VRAM, RADEON_FLAG_NO_INTERPROCESS_SHARING); + RADEON_DOMAIN_VRAM, + RADEON_FLAG_NO_INTERPROCESS_SHARING | + device->physical_device->cpdma_prefetch_writes_memory ? + 0 : RADEON_FLAG_READ_ONLY); slab->ptr = (char*)device->ws->buffer_map(slab->bo); list_inithead(&slab->shaders); -- 2.30.2