From a3d93eec7cbd3fb733c1ef3b16903265e8e61b23 Mon Sep 17 00:00:00 2001 From: Bas Nieuwenhuizen Date: Sun, 17 Jun 2018 03:37:49 +0200 Subject: [PATCH] radv: Use less conservative approximation for context rolls. Drops the number of time we set the scissor by 4x for F1 2017, which results in a consistent performance improvement of about 4%. Reviewed-by: Samuel Pitoiset --- src/amd/vulkan/radv_cmd_buffer.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index a07717c7196..ccaab63b84b 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/amd/vulkan/radv_cmd_buffer.c @@ -3299,10 +3299,13 @@ static bool radv_need_late_scissor_emission(struct radv_cmd_buffer *cmd_buffer, if (!cmd_buffer->device->physical_device->has_scissor_bug) return false; + uint32_t used_states = cmd_buffer->state.pipeline->graphics.needed_dynamic_state | ~RADV_CMD_DIRTY_DYNAMIC_ALL; + + /* Index & Vertex buffer don't change context regs, and pipeline is handled later. */ + used_states &= ~(RADV_CMD_DIRTY_INDEX_BUFFER | RADV_CMD_DIRTY_VERTEX_BUFFER | RADV_CMD_DIRTY_PIPELINE); + /* Assume all state changes except these two can imply context rolls. */ - if (cmd_buffer->state.dirty & ~(RADV_CMD_DIRTY_INDEX_BUFFER | - RADV_CMD_DIRTY_VERTEX_BUFFER | - RADV_CMD_DIRTY_PIPELINE)) + if (cmd_buffer->state.dirty & used_states) return true; if (cmd_buffer->state.emitted_pipeline != cmd_buffer->state.pipeline) -- 2.30.2