From a40f0430347c07bf2d5794642fe02f5dd248a473 Mon Sep 17 00:00:00 2001 From: Topi Pohjolainen Date: Wed, 28 Jun 2017 12:07:32 +0300 Subject: [PATCH] intel/isl: Align non-tiled horizontally by cache line in order to support blit engine. Reviewed-by: Jason Ekstrand Signed-off-by: Topi Pohjolainen --- src/intel/isl/isl.c | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c index 7d1356f0acf..d4a7d00208f 100644 --- a/src/intel/isl/isl.c +++ b/src/intel/isl/isl.c @@ -1268,9 +1268,23 @@ isl_calc_row_pitch(const struct isl_device *dev, const struct isl_extent2d *phys_total_el, uint32_t *out_row_pitch) { - const uint32_t alignment = + uint32_t alignment = isl_calc_row_pitch_alignment(surf_info, tile_info); + /* If pitch isn't given and it can be chosen freely, align it by cache line + * allowing one to use blit engine on the surface. + */ + if (surf_info->row_pitch == 0 && tile_info->tiling == ISL_TILING_LINEAR) { + /* From the Broadwell PRM docs for XY_SRC_COPY_BLT::SourceBaseAddress: + * + * "Base address of the destination surface: X=0, Y=0. Lower 32bits + * of the 48bit addressing. When Src Tiling is enabled (Bit_15 + * enabled), this address must be 4KB-aligned. When Tiling is not + * enabled, this address should be CL (64byte) aligned." + */ + alignment = MAX2(alignment, 64); + } + const uint32_t min_row_pitch = isl_calc_min_row_pitch(dev, surf_info, tile_info, phys_total_el, alignment); -- 2.30.2