From a412de98913cab0f80cfb023da8138fc5297c1e3 Mon Sep 17 00:00:00 2001 From: Richard Biener Date: Fri, 2 Nov 2018 07:53:48 +0000 Subject: [PATCH] re PR tree-optimization/87776 (Compile time hog during RPO VN) 2018-11-02 Richard Biener PR tree-optimization/87776 * tree-ssa-sccvn.c (do_rpo_vn): Do not mark backedges executable when iterating but running into rpo-vn-max-loop-depth and not eliding the iteration. * gcc.dg/torture/pr87776.c: New testcase. From-SVN: r265739 --- gcc/ChangeLog | 7 +++++ gcc/testsuite/ChangeLog | 5 ++++ gcc/testsuite/gcc.dg/torture/pr87776.c | 40 ++++++++++++++++++++++++++ gcc/tree-ssa-sccvn.c | 3 +- 4 files changed, 54 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/torture/pr87776.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 9d5ed94615a..90d11f5038d 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2018-11-02 Richard Biener + + PR tree-optimization/87776 + * tree-ssa-sccvn.c (do_rpo_vn): Do not mark backedges + executable when iterating but running into rpo-vn-max-loop-depth + and not eliding the iteration. + 2018-11-30 Jan Hubicka * tree.c (free_lang_data_in_decl): Free TREE_TYPE and alignment of diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 98703db2305..e3f4e8ef4e3 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2018-11-02 Richard Biener + + PR tree-optimization/87776 + * gcc.dg/torture/pr87776.c: New testcase. + 2018-11-01 Marek Polacek Implement P0846R0, ADL and function templates. diff --git a/gcc/testsuite/gcc.dg/torture/pr87776.c b/gcc/testsuite/gcc.dg/torture/pr87776.c new file mode 100644 index 00000000000..1f150702dcf --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr87776.c @@ -0,0 +1,40 @@ +/* { dg-do compile } */ +/* { dg-additional-options "--param rpo-vn-max-loop-depth=2" } */ + +int wp; + +void +ff (void) +{ + int *s3 = ℘ + + for (wp = 0; wp < 1; ++wp) + { + if (wp != 0) + { +o8: + ; + } + else + { +b7: + while (wp < 1) + { + } + } + + for (*s3 = 0; *s3 < 1; ++*s3) + { + for (wp = 0; wp < 1; ++wp) + for (wp = 0; wp < 1; ++wp) + { + } + + for (wp = 0; wp < 1; ++wp) + goto o8; + + for (wp = 0; wp < 1; ++wp) + goto b7; + } + } +} diff --git a/gcc/tree-ssa-sccvn.c b/gcc/tree-ssa-sccvn.c index 38330754769..43641916d52 100644 --- a/gcc/tree-ssa-sccvn.c +++ b/gcc/tree-ssa-sccvn.c @@ -6449,7 +6449,6 @@ do_rpo_vn (function *fn, edge entry, bitmap exit_bbs, FOR_EACH_EDGE (e, ei, header->preds) if (e->flags & EDGE_DFS_BACK) { - e->flags |= EDGE_EXECUTABLE; /* There can be a non-latch backedge into the header which is part of an outer irreducible region. We cannot avoid iterating this block then. */ @@ -6462,6 +6461,8 @@ do_rpo_vn (function *fn, edge entry, bitmap exit_bbs, e->src->index, e->dest->index, loop->num); non_latch_backedge = true; } + else + e->flags |= EDGE_EXECUTABLE; } rpo_state[bb_to_rpo[header->index]].iterate = non_latch_backedge; } -- 2.30.2