From a4497d2f8486502ab5140ec5168d5f13ec375155 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Tue, 21 Aug 2018 10:47:47 -0400 Subject: [PATCH] Remove unnecessary ternary operator in m32c-tdep.c Bug 17816 pointed out a useless use of the ternary operator: case 0x0: sd.reg = (size == 1 ? &st->r0 : &st->r0); break; I believe that this is right. If size is 1, the instruction refers to part of r0, while if size is 2, the instruction refers to the whole of r0. gdb/ChangeLog: PR gdb/17816 * m32c-tdep.c (m32c_decode_srcdest4): Remove unnecessary ternary operator. --- gdb/ChangeLog | 6 ++++++ gdb/m32c-tdep.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ff4d1cb5483..9173bf94611 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2018-08-21 Simon Marchi + + PR gdb/17816 + * m32c-tdep.c (m32c_decode_srcdest4): Remove unnecessary ternary + operator. + 2018-08-19 Simon Marchi * solib-svr4.c (svr4_exec_displacement): Fix formatting. diff --git a/gdb/m32c-tdep.c b/gdb/m32c-tdep.c index fc6277ef5c1..6fa24452da9 100644 --- a/gdb/m32c-tdep.c +++ b/gdb/m32c-tdep.c @@ -1236,7 +1236,7 @@ m32c_decode_srcdest4 (struct m32c_pv_state *st, switch (code) { - case 0x0: sd.reg = (size == 1 ? &st->r0 : &st->r0); break; + case 0x0: sd.reg = &st->r0; break; case 0x1: sd.reg = (size == 1 ? &st->r0 : &st->r1); break; case 0x2: sd.reg = (size == 1 ? &st->r1 : &st->r2); break; case 0x3: sd.reg = (size == 1 ? &st->r1 : &st->r3); break; -- 2.30.2