From a466edac5f9913e3373e59335607e9666a0ac8c7 Mon Sep 17 00:00:00 2001 From: Hafiz Abid Qadeer Date: Tue, 18 Sep 2018 11:23:30 +0100 Subject: [PATCH] Add '_' in the match pattern. I was looking at GDB testcase results for arm-eabi target with qemu and noticed that register groups returned by the qemu can have '_' in the name e.g. 'cp_regs'. The reggroups.exp fails to recognize that as group name. Fixed by adding '_' in the pattern. 2018-09-20 Hafiz Abid Qadeer gdb.base/reggroups.exp (fetch_reggroups): Add '_' in match pattern. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.base/reggroups.exp | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 53173c2f18c..3fabd80aeb9 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2018-09-20 Hafiz Abid Qadeer + + gdb.base/reggroups.exp (fetch_reggroups): Add '_' in match pattern. + 2018-09-18 Sandra Loosemore * gdb.base/complete-empty.exp: Skip tab-completion tests if diff --git a/gdb/testsuite/gdb.base/reggroups.exp b/gdb/testsuite/gdb.base/reggroups.exp index 294f90931fb..036c97b8446 100644 --- a/gdb/testsuite/gdb.base/reggroups.exp +++ b/gdb/testsuite/gdb.base/reggroups.exp @@ -43,7 +43,7 @@ proc fetch_reggroups {test} { -re "^ Group\[ \t\]+Type\[ \t\]+\r\n" { exp_continue } - -re "^ (\[0-9a-zA-Z-\]+)\[ \t\]+(user|internal)\[ \t\]+\r\n" { + -re "^ (\[_0-9a-zA-Z-\]+)\[ \t\]+(user|internal)\[ \t\]+\r\n" { lappend reggroups $expect_out(1,string) exp_continue } -- 2.30.2