From a4c4e0103a5997eca381d1dc8d8cb124634032f2 Mon Sep 17 00:00:00 2001 From: Rob Clark Date: Wed, 5 Aug 2020 10:27:10 -0700 Subject: [PATCH] glsl: remove LowerPrecisionTemporaries MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Signed-off-by: Rob Clark Reviewed-by: Alyssa Rosenzweig Reviewed-by: Marek Olšák Reviewed-by: Eric Anholt Part-of: --- src/compiler/glsl/lower_precision.cpp | 6 ++---- src/compiler/glsl/standalone.cpp | 1 - src/mesa/main/mtypes.h | 6 ------ src/mesa/state_tracker/st_extensions.c | 1 - 4 files changed, 2 insertions(+), 12 deletions(-) diff --git a/src/compiler/glsl/lower_precision.cpp b/src/compiler/glsl/lower_precision.cpp index 07798f3b200..1685483bacd 100644 --- a/src/compiler/glsl/lower_precision.cpp +++ b/src/compiler/glsl/lower_precision.cpp @@ -1333,8 +1333,6 @@ lower_precision(const struct gl_shader_compiler_options *options, find_lowerable_rvalues(options, instructions, v.lowerable_rvalues); visit_list_elements(&v, instructions); - if (options->LowerPrecisionTemporaries) { - lower_variables_visitor vars(options); - visit_list_elements(&vars, instructions); - } + lower_variables_visitor vars(options); + visit_list_elements(&vars, instructions); } diff --git a/src/compiler/glsl/standalone.cpp b/src/compiler/glsl/standalone.cpp index c1510d51e0b..ca187001186 100644 --- a/src/compiler/glsl/standalone.cpp +++ b/src/compiler/glsl/standalone.cpp @@ -441,7 +441,6 @@ standalone_compile_shader(const struct standalone_options *_options, options->LowerPrecisionFloat16 = true; options->LowerPrecisionInt16 = true; options->LowerPrecisionDerivatives = true; - options->LowerPrecisionTemporaries = true; options->LowerPrecisionConstants = true; } } diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h index 1df6d34b5d4..f78d2b5d980 100644 --- a/src/mesa/main/mtypes.h +++ b/src/mesa/main/mtypes.h @@ -3217,12 +3217,6 @@ struct gl_shader_compiler_options */ GLboolean LowerPrecisionConstants; - /** - * This enables 16-bit phis in NIR, 16-bit loop counters, 16-bit indirect - * arrays, etc. - */ - GLboolean LowerPrecisionTemporaries; - /** * \name Forms of indirect addressing the driver cannot do. */ diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index bd6203a1901..af454dca069 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/state_tracker/st_extensions.c @@ -348,7 +348,6 @@ void st_init_limits(struct pipe_screen *screen, screen->get_shader_param(screen, sh, PIPE_SHADER_CAP_INT16); options->LowerPrecisionConstants = screen->get_shader_param(screen, sh, PIPE_SHADER_CAP_GLSL_16BIT_CONSTS); - options->LowerPrecisionTemporaries = true; } c->MaxUserAssignableUniformLocations = -- 2.30.2