From a502b0bbb8f3fb7dca4f2a12aa04afa28173f0c2 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Thu, 13 Jul 2017 08:10:57 -0700 Subject: [PATCH] Always delete $testarchive first Always delete $testarchive first so that it exists only when it is supported, * testsuite/binutils-all/objdump.exp: Always delete $testarchive first. --- binutils/ChangeLog | 5 +++++ binutils/testsuite/binutils-all/objdump.exp | 12 +++++------- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/binutils/ChangeLog b/binutils/ChangeLog index 4f7521a8e48..19de4a00094 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,8 @@ +2017-07-13 H.J. Lu + + * testsuite/binutils-all/objdump.exp: Always delete $testarchive + first. + 2017-07-12 Alan Modra * po/bg.po: Update from translationproject.org/latest/binutils/. diff --git a/binutils/testsuite/binutils-all/objdump.exp b/binutils/testsuite/binutils-all/objdump.exp index 3dee405340a..472b749df81 100644 --- a/binutils/testsuite/binutils-all/objdump.exp +++ b/binutils/testsuite/binutils-all/objdump.exp @@ -75,18 +75,16 @@ if [is_remote host] { set testfile2 tmpdir/bintest2.o } +# $testarchive exists only if it is supported. +set testarchive tmpdir/bintest.a +remote_file host file delete $testarchive if { ![istarget "alpha-*-*"] || [is_elf_format] } then { - remote_file host file delete tmpdir/bintest.a set got [binutils_run $AR "rc tmpdir/bintest.a $testfile2"] if ![string match "" $got] then { fail "bintest.a" remote_file host delete tmpdir/bintest.a - } else { - if [is_remote host] { - set testarchive [remote_download host tmpdir/bintest.a] - } else { - set testarchive tmpdir/bintest.a - } + } elseif [is_remote host] { + set testarchive [remote_download host tmpdir/bintest.a] } remote_file host delete tmpdir/bintest2.o } -- 2.30.2