From a6ea2592a983a67f7c537fb97eab7c9e9ba675c7 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Thu, 2 Dec 2021 14:12:44 -0500 Subject: [PATCH] gdb: remove unexpected xstrdup in _initialize_maint_test_settings That xstrdup is not correct, since we are assigning an std::string. The result of xstrdup is used to initialize the string, and then lost forever. Remove it. Change-Id: Ief7771055e4bfd643ef3b285ec9fb7b1bfd14335 --- gdb/maint-test-settings.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/maint-test-settings.c b/gdb/maint-test-settings.c index 9f50088833a..ae61caa0391 100644 --- a/gdb/maint-test-settings.c +++ b/gdb/maint-test-settings.c @@ -83,7 +83,7 @@ void _initialize_maint_test_settings (); void _initialize_maint_test_settings () { - maintenance_test_settings_filename = xstrdup ("/foo/bar"); + maintenance_test_settings_filename = "/foo/bar"; add_setshow_prefix_cmd ("test-settings", class_maintenance, _("\ -- 2.30.2