From a72eb993e8540239f99cc646467cd63f01f0f18f Mon Sep 17 00:00:00 2001 From: =?utf8?q?Tiago=20M=C3=BCck?= Date: Tue, 15 Oct 2019 16:02:55 -0500 Subject: [PATCH] mem-ruby: removed unused checkCoherence MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Change-Id: I108b95513f2828470fe70bad5f136b0721598582 Signed-off-by: Tiago Mück Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/21924 Reviewed-by: Jason Lowe-Power Maintainer: Jason Lowe-Power Tested-by: kokoro --- src/mem/ruby/protocol/RubySlicc_Types.sm | 3 --- src/mem/ruby/system/GPUCoalescer.cc | 7 ------- src/mem/ruby/system/GPUCoalescer.hh | 1 - src/mem/ruby/system/Sequencer.cc | 8 -------- src/mem/ruby/system/Sequencer.hh | 1 - 5 files changed, 20 deletions(-) diff --git a/src/mem/ruby/protocol/RubySlicc_Types.sm b/src/mem/ruby/protocol/RubySlicc_Types.sm index fc1f7f398..ff574b5e2 100644 --- a/src/mem/ruby/protocol/RubySlicc_Types.sm +++ b/src/mem/ruby/protocol/RubySlicc_Types.sm @@ -128,7 +128,6 @@ structure (Sequencer, external = "yes") { void writeCallbackScFail(Addr, DataBlock); bool llscCheckMonitor(Addr); - void checkCoherence(Addr); void evictionCallback(Addr); void recordRequestType(SequencerRequestType); bool checkResourceAvailable(CacheResourceType, Addr); @@ -148,7 +147,6 @@ structure (GPUCoalescer, external = "yes") { Cycles, Cycles, Cycles); void writeCallback(Addr, MachineType, DataBlock, Cycles, Cycles, Cycles, bool); - void checkCoherence(Addr); void evictionCallback(Addr); void recordCPReadCallBack(MachineID, MachineID); void recordCPWriteCallBack(MachineID, MachineID); @@ -169,7 +167,6 @@ structure (VIPERCoalescer, external = "yes") { Cycles, Cycles, Cycles, bool); void invCallback(Addr); void wbCallback(Addr); - void checkCoherence(Addr); void evictionCallback(Addr); } diff --git a/src/mem/ruby/system/GPUCoalescer.cc b/src/mem/ruby/system/GPUCoalescer.cc index 93275cbf3..a7b658ee1 100644 --- a/src/mem/ruby/system/GPUCoalescer.cc +++ b/src/mem/ruby/system/GPUCoalescer.cc @@ -976,13 +976,6 @@ GPUCoalescer::print(ostream& out) const << "]"; } -// this can be called from setState whenever coherence permissions are -// upgraded when invoked, coherence violations will be checked for the -// given block -void -GPUCoalescer::checkCoherence(Addr addr) -{ -} void GPUCoalescer::recordRequestType(SequencerRequestType requestType) { diff --git a/src/mem/ruby/system/GPUCoalescer.hh b/src/mem/ruby/system/GPUCoalescer.hh index 13211738d..3230ef1ee 100644 --- a/src/mem/ruby/system/GPUCoalescer.hh +++ b/src/mem/ruby/system/GPUCoalescer.hh @@ -176,7 +176,6 @@ class GPUCoalescer : public RubyPort bool empty() const; void print(std::ostream& out) const; - void checkCoherence(Addr address); void markRemoved(); void removeRequest(GPUCoalescerRequest* request); diff --git a/src/mem/ruby/system/Sequencer.cc b/src/mem/ruby/system/Sequencer.cc index de7941a49..aa134f4fa 100644 --- a/src/mem/ruby/system/Sequencer.cc +++ b/src/mem/ruby/system/Sequencer.cc @@ -738,14 +738,6 @@ Sequencer::print(ostream& out) const << "]"; } -// this can be called from setState whenever coherence permissions are -// upgraded when invoked, coherence violations will be checked for the -// given block -void -Sequencer::checkCoherence(Addr addr) -{ -} - void Sequencer::recordRequestType(SequencerRequestType requestType) { DPRINTF(RubyStats, "Recorded statistic: %s\n", diff --git a/src/mem/ruby/system/Sequencer.hh b/src/mem/ruby/system/Sequencer.hh index bb9360719..ebca56834 100644 --- a/src/mem/ruby/system/Sequencer.hh +++ b/src/mem/ruby/system/Sequencer.hh @@ -124,7 +124,6 @@ class Sequencer : public RubyPort { deschedule(deadlockCheckEvent); } void print(std::ostream& out) const; - void checkCoherence(Addr address); void markRemoved(); void evictionCallback(Addr address); -- 2.30.2