From a786ac4d5351e4e8eae0e6abf7577cd330b2a232 Mon Sep 17 00:00:00 2001
From: Eddie Hung <eddieh@ece.ubc.ca>
Date: Fri, 15 Feb 2019 13:00:13 -0800
Subject: [PATCH] Refactor

---
 passes/techmap/abc9.cc | 61 ++++++++++++++++++++++--------------------
 1 file changed, 32 insertions(+), 29 deletions(-)

diff --git a/passes/techmap/abc9.cc b/passes/techmap/abc9.cc
index 285851ea4..b32facc48 100644
--- a/passes/techmap/abc9.cc
+++ b/passes/techmap/abc9.cc
@@ -449,11 +449,17 @@ void abc9_module(RTLIL::Design *design, RTLIL::Module *current_module, std::stri
 		RTLIL::Module *mapped_mod = mapped_design->modules_["\\netlist"];
 		if (mapped_mod == NULL)
 			log_error("ABC output file does not contain a module `netlist'.\n");
+		pool<RTLIL::SigBit> output_bits;
 		for (auto &it : mapped_mod->wires_) {
 			RTLIL::Wire *w = it.second;
-			RTLIL::Wire *wire = module->addWire(remap_name(w->name), GetSize(w));
-			if (markgroups) wire->attributes["\\abcgroup"] = map_autoidx;
-			design->select(module, wire);
+			RTLIL::Wire *remap_wire = module->addWire(remap_name(w->name), GetSize(w));
+			if (markgroups) remap_wire->attributes["\\abcgroup"] = map_autoidx;
+			design->select(module, remap_wire);
+			RTLIL::Wire *wire = module->wire(w->name);
+			if (w->port_output) {
+				for (int i = 0; i < GetSize(remap_wire); i++)
+					output_bits.insert({wire, i});
+			}
 		}
 
 		std::map<std::string, int> cell_stats;
@@ -700,8 +706,27 @@ void abc9_module(RTLIL::Design *design, RTLIL::Module *current_module, std::stri
 		//		module->connect(conn);
 		//	}
 
-		pool<RTLIL::SigBit> output_bits;
-		std::vector<RTLIL::SigSig> connections;
+		// Go through all cell output connections,
+		// and for those output ports driving wires
+		// also driven by mapped_mod, disconnect them
+		for (auto cell : module->cells()) {
+			for (auto &it : cell->connections_) {
+				auto port_name = it.first;
+				if (!cell->output(port_name)) continue;
+				auto &signal = it.second;
+				if (!signal.is_bit()) continue;
+				if (output_bits.count(signal.as_bit()))
+					signal = RTLIL::State::Sx;
+			}
+		}
+		// Do the same for module connections
+		for (auto &it : module->connections_) {
+			auto &signal = it.first;
+			if (!signal.is_bit()) continue;
+			if (output_bits.count(signal.as_bit()))
+				signal = RTLIL::State::Sx;
+		}
+
 		// Stitch in mapped_mod's inputs/outputs into module
 		for (auto &it : mapped_mod->wires_) {
 			RTLIL::Wire *w = it.second;
@@ -715,7 +740,7 @@ void abc9_module(RTLIL::Design *design, RTLIL::Module *current_module, std::stri
 				conn.first = remap_wire;
 				conn.second = RTLIL::SigSpec(wire, 0, GetSize(remap_wire));
 				in_wires++;
-				connections.emplace_back(std::move(conn));
+				module->connect(conn);
 				printf("INPUT: assign %s = %s\n", remap_wire->name.c_str(), wire->name.c_str());
 			}
 			else if (w->port_output) {
@@ -726,32 +751,10 @@ void abc9_module(RTLIL::Design *design, RTLIL::Module *current_module, std::stri
 				for (int i = 0; i < GetSize(remap_wire); i++)
 					output_bits.insert({wire, i});
 				printf("OUTPUT: assign %s = %s\n", wire->name.c_str(), remap_wire->name.c_str());
-				connections.emplace_back(std::move(conn));
+				module->connect(conn);
 			}
 			else log_abort();
 		}
-		// Go through all cell output connections,
-		// and for those output ports driving wires
-		// also driven by mapped_mod, disconnect them
-		for (auto cell : module->cells()) {
-			for (auto &it : cell->connections_) {
-				auto port_name = it.first;
-				if (!cell->output(port_name)) continue;
-				auto &signal = it.second;
-				if (!signal.is_bit()) continue;
-				if (output_bits.count(signal.as_bit()))
-					signal = RTLIL::State::Sx;
-			}
-		}
-		// Do the same for module connections
-		for (auto &it : module->connections_) {
-			auto &signal = it.first;
-			if (!signal.is_bit()) continue;
-			if (output_bits.count(signal.as_bit()))
-				signal = RTLIL::State::Sx;
-		}
-		for (const auto &c : connections)
-			module->connect(c);
 
 		//log("ABC RESULTS:        internal signals: %8d\n", int(signal_list.size()) - in_wires - out_wires);
 		log("ABC RESULTS:           input signals: %8d\n", in_wires);
-- 
2.30.2