From a7c88acd1ed0b886e7aff708df153c5663a9ebbb Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Wed, 29 Jan 2014 14:25:18 +0400 Subject: [PATCH] Minor reformatting in valops.c::value_slice I noticed that a small lexical block was over indented by 2 characters. So this patch starts by reducing the indentation. While looking at this area of the code, I also noticed a couple of lines that had trailing spaces, so this patch also removes them. And finally, it fixes one tiny to put the assignment operator at the start of the next line, rather than at the end of the first line. gdb/ChangeLog: * valops.c (value_slice): Minor reformatting. --- gdb/ChangeLog | 4 ++++ gdb/valops.c | 43 ++++++++++++++++++++++--------------------- 2 files changed, 26 insertions(+), 21 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index a7097e8704e..5b3cb688ccf 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2014-01-29 Joel Brobecker + + * valops.c (value_slice): Minor reformatting. + 2014-01-28 Ulrich Weigand  * ppc64-tdep.c (ppc64_standard_linkage7): Fix typo. diff --git a/gdb/valops.c b/gdb/valops.c index deb01cbad88..898401dc13c 100644 --- a/gdb/valops.c +++ b/gdb/valops.c @@ -3614,32 +3614,33 @@ value_slice (struct value *array, int lowbound, int length) done with it. */ slice_range_type = create_range_type ((struct type *) NULL, TYPE_TARGET_TYPE (range_type), - lowbound, + lowbound, lowbound + length - 1); - { - struct type *element_type = TYPE_TARGET_TYPE (array_type); - LONGEST offset = - (lowbound - lowerbound) * TYPE_LENGTH (check_typedef (element_type)); + { + struct type *element_type = TYPE_TARGET_TYPE (array_type); + LONGEST offset + = (lowbound - lowerbound) * TYPE_LENGTH (check_typedef (element_type)); - slice_type = create_array_type ((struct type *) NULL, - element_type, - slice_range_type); - TYPE_CODE (slice_type) = TYPE_CODE (array_type); + slice_type = create_array_type ((struct type *) NULL, + element_type, + slice_range_type); + TYPE_CODE (slice_type) = TYPE_CODE (array_type); - if (VALUE_LVAL (array) == lval_memory && value_lazy (array)) - slice = allocate_value_lazy (slice_type); - else - { - slice = allocate_value (slice_type); - value_contents_copy (slice, 0, array, offset, - TYPE_LENGTH (slice_type)); - } + if (VALUE_LVAL (array) == lval_memory && value_lazy (array)) + slice = allocate_value_lazy (slice_type); + else + { + slice = allocate_value (slice_type); + value_contents_copy (slice, 0, array, offset, + TYPE_LENGTH (slice_type)); + } + + set_value_component_location (slice, array); + VALUE_FRAME_ID (slice) = VALUE_FRAME_ID (array); + set_value_offset (slice, value_offset (array) + offset); + } - set_value_component_location (slice, array); - VALUE_FRAME_ID (slice) = VALUE_FRAME_ID (array); - set_value_offset (slice, value_offset (array) + offset); - } return slice; } -- 2.30.2