From a80f2680dbf07c713e3d58bc0906b7ed52f911e2 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Thu, 26 May 2022 10:40:32 -0600 Subject: [PATCH] Simplify varobj "change" logic varobj used to store 'print_value' as a C string, where NULL was a valid value, and so it had logic to handle this situation. However, at some point this was changed to be a std::string, and so the code can be simplified in this spot. --- gdb/varobj.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/gdb/varobj.c b/gdb/varobj.c index 741fdb6a03b..1aca015a21a 100644 --- a/gdb/varobj.c +++ b/gdb/varobj.c @@ -1344,11 +1344,8 @@ install_new_value (struct varobj *var, struct value *value, bool initial) { print_value = varobj_value_get_print_value (var->value.get (), var->format, var); - if ((var->print_value.empty () && !print_value.empty ()) - || (!var->print_value.empty () && print_value.empty ()) - || (!var->print_value.empty () && !print_value.empty () - && var->print_value != print_value)) - changed = true; + if (var->print_value != print_value) + changed = true; } var->print_value = print_value; -- 2.30.2