From a84aff585b6fea6445ae831d523f088c9662af73 Mon Sep 17 00:00:00 2001 From: Kyrylo Tkachov Date: Wed, 24 Jan 2018 14:43:52 +0000 Subject: [PATCH] [testsuite] Fix arm options in gcc.dg/lto/20110201-1_0.c This test fails on arm hardfloat targets because it sets an explicit -mfloat-abi=softfp. The usual approach to setting the NEON options is to use dg-add-options arm_neon. But in the lto tests we don't have that framework, we can only set them explicitly with dg-lto-options. The solution is to remove the explicit -mfloat-abi=softfp and instead add an effective target check for arm_neon_ok_no_float_abi that makes sure we only run this test if -mfpu=neon is enough to get NEON without any -mfloat-abi options. In fact, this is what the comment above check_effective_target_arm_neon_ok_no_float_abi_nocache recommends for lto tests. That way on my hardfloat toolchain the test doesn't try to link the softfp binary against a hard-float runtime/test glue and all is good. I've tested that the test is appropriately skipped when testing a --with-float=soft toolchain. * gcc.dg/lto/20110201-1_0.c: Remove explicit -mfloat-abi=softfp option. Add arm_neon_ok_no_float_abi check. From-SVN: r257017 --- gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.dg/lto/20110201-1_0.c | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index b13ec74815a..af42b95cf87 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2018-01-24 Kyrylo Tkachov + + * gcc.dg/lto/20110201-1_0.c: Remove explicit -mfloat-abi=softfp + option. Add arm_neon_ok_no_float_abi check. + 2018-01-24 Richard Biener PR tree-optimization/83176 diff --git a/gcc/testsuite/gcc.dg/lto/20110201-1_0.c b/gcc/testsuite/gcc.dg/lto/20110201-1_0.c index 2144f071480..871a49fe189 100644 --- a/gcc/testsuite/gcc.dg/lto/20110201-1_0.c +++ b/gcc/testsuite/gcc.dg/lto/20110201-1_0.c @@ -1,6 +1,7 @@ /* { dg-lto-do run } */ /* { dg-lto-options { { -O0 -flto -fno-math-errno } } } */ -/* { dg-lto-options { "-O0 -flto -fno-math-errno -mfloat-abi=softfp -mfpu=neon-vfpv4" } { target arm*-*-* } } */ +/* { dg-lto-options { "-O0 -flto -fno-math-errno -mfpu=neon-vfpv4" } { target arm*-*-* } } */ +/* { dg-require-effective-target arm_neon_ok_no_float_abi { target arm*-*-* } } */ /* { dg-require-linker-plugin "" } */ /* { dg-require-effective-target sqrt_insn } */ -- 2.30.2