From a84bb2a0790125f5fb5df65b7873fb6076164527 Mon Sep 17 00:00:00 2001 From: Jon Turney Date: Sat, 29 Feb 2020 13:33:35 +0000 Subject: [PATCH] gdb: Move defs.h before any system header in debuginfod-support.c MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit * defs.h includes config.h * config.h may define _GNU_SOURCE * if _GNU_SOURCE is defined, that must be before including any system header (see feature_test_macro(7)) This is necessary to ensure that a prototype for mkostemp() is brought into scope by when compiling filestuff.h, on platforms where _GNU_SOURCE isn't unconditionally defined for C++. In file included from ../../gdb/../gdbsupport/scoped_fd.h:24, from ../../gdb/debuginfod-support.c:22: ../../gdb/../gdbsupport/filestuff.h: In function ‘int gdb_mkostemp_cloexec(char*, int)’: ../../gdb/../gdbsupport/filestuff.h:59:10: error: ‘mkostemp’ was not declared in this scope; did you mean ‘mkstemp’? gdb/ChangeLog: 2020-02-29 Jon Turney * debuginfod-support.c: Include defs.h first. --- gdb/ChangeLog | 4 ++++ gdb/debuginfod-support.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 5f49542fb82..591ef402863 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2020-02-29 Jon Turney + + * debuginfod-support.c: Include defs.h first. + 2020-02-28 Tom de Vries * symfile.c (set_initial_language): Use default language for lookup. diff --git a/gdb/debuginfod-support.c b/gdb/debuginfod-support.c index e0f0fac0766..f4a227b0403 100644 --- a/gdb/debuginfod-support.c +++ b/gdb/debuginfod-support.c @@ -16,8 +16,8 @@ You should have received a copy of the GNU General Public License along with this program. If not, see . */ -#include #include "defs.h" +#include #include "cli/cli-style.h" #include "gdbsupport/scoped_fd.h" #include "debuginfod-support.h" -- 2.30.2