From aa8dea091f83d726078a543040a5526819f21683 Mon Sep 17 00:00:00 2001 From: Richard Henderson Date: Thu, 20 Jun 2002 16:23:54 -0700 Subject: [PATCH] typeck.c (mark_addressable): Don't test TREE_ADDRESSABLE early. * typeck.c (mark_addressable): Don't test TREE_ADDRESSABLE early. Call put_var_into_stack. * g++.dg/opt/asm1.C: New. From-SVN: r54862 --- gcc/cp/ChangeLog | 6 ++++++ gcc/cp/typeck.c | 7 ++++--- gcc/testsuite/g++.dg/opt/asm1.C | 9 +++++++++ 3 files changed, 19 insertions(+), 3 deletions(-) create mode 100644 gcc/testsuite/g++.dg/opt/asm1.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 4a37ab3fe0b..8cc664e3b3f 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,9 @@ +2002-06-20 Richard Henderson + + PR c++/6747 + * typeck.c (mark_addressable): Don't test TREE_ADDRESSABLE early. + Call put_var_into_stack. + 2002-06-20 Kaveh R. Ghazi * spew.c (remove_last_token): Use ARRAY_SIZE in lieu of explicit diff --git a/gcc/cp/typeck.c b/gcc/cp/typeck.c index 5ea8bdb4f28..c1338d934e3 100644 --- a/gcc/cp/typeck.c +++ b/gcc/cp/typeck.c @@ -4805,9 +4805,6 @@ cxx_mark_addressable (exp) { register tree x = exp; - if (TREE_ADDRESSABLE (x) == 1) - return true; - while (1) switch (TREE_CODE (x)) { @@ -4826,6 +4823,8 @@ cxx_mark_addressable (exp) TREE_ADDRESSABLE (x) = 1; /* so compiler doesn't die later */ return true; } + /* FALLTHRU */ + case VAR_DECL: /* Caller should not be trying to mark initialized constant fields addressable. */ @@ -4833,6 +4832,7 @@ cxx_mark_addressable (exp) || DECL_IN_AGGR_P (x) == 0 || TREE_STATIC (x) || DECL_EXTERNAL (x), 314); + /* FALLTHRU */ case CONST_DECL: case RESULT_DECL: @@ -4841,6 +4841,7 @@ cxx_mark_addressable (exp) warning ("address requested for `%D', which is declared `register'", x); TREE_ADDRESSABLE (x) = 1; + put_var_into_stack (x); return true; case FUNCTION_DECL: diff --git a/gcc/testsuite/g++.dg/opt/asm1.C b/gcc/testsuite/g++.dg/opt/asm1.C new file mode 100644 index 00000000000..3f932a6d70c --- /dev/null +++ b/gcc/testsuite/g++.dg/opt/asm1.C @@ -0,0 +1,9 @@ +// PR c++/6747 +// { dg-do compile } +// { dg-options "-O" } + +void foo() +{ + union { double d; char c[sizeof(double)]; } tmp; + __asm__ ("" : "=m" (tmp.d)); // { dg-bogus "not directly addressable" } +} -- 2.30.2