From ab1c4e88612fb125c21eaa4374093161bb18fd10 Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Fri, 10 May 2013 13:25:28 +0000 Subject: [PATCH] Remove FIXME in solib-aix.c:solib_aix_relocate_section_addresses This issue should now be fixed thanks to a change in bfd removing the SEC_ALLOC flag from all sections that do not get mapped to memory. gdb/ChangeLog: * solib-aix.c (solib_aix_relocate_section_addresses): Remove FIXME comment. --- gdb/ChangeLog | 5 +++++ gdb/solib-aix.c | 10 ---------- 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 9f7b97228da..f7b27f58b44 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -4,6 +4,11 @@ For the .bss section action, apply the same offset as the .data section. +2013-05-10 Joel Brobecker + + * solib-aix.c (solib_aix_relocate_section_addresses): + Remove FIXME comment. + 2013-05-10 Joel Brobecker PR tdep/15420: diff --git a/gdb/solib-aix.c b/gdb/solib-aix.c index 4672b588ce3..5d15e7045af 100644 --- a/gdb/solib-aix.c +++ b/gdb/solib-aix.c @@ -432,16 +432,6 @@ solib_aix_relocate_section_addresses (struct so_list *so, else { /* All other sections should not be relocated. */ - /* FIXME: GDB complains that the .loader section sometimes - overlaps with other sections (Eg: the .data section). - As far as I can tell, the loader section had the LOAD flag - set, but not the RELOC. So it should not be relocated. - There seems to be a problem there, and maybe it has to do - with setting sec->addr to 0 (when the vma is indeed 0). - But even if there wasn't, the problem then becomes the fact - that many shared objects inside shared libraries have - a .loader section whose vma is 0, thus also triggering - an overlap warning. */ sec->addr = bfd_section_vma (abfd, bfd_sect); sec->endaddr = sec->addr + bfd_section_size (abfd, bfd_sect); } -- 2.30.2