From ab22883b701867cefe872dcd6942ebdf2e84db32 Mon Sep 17 00:00:00 2001 From: Uros Bizjak Date: Sat, 18 Jul 2015 11:50:37 +0200 Subject: [PATCH] re PR target/66922 (wrong code for bit-field struct at -O1 and above on x86_64-linux-gnu) PR target/66922 * config/i386/i386.c (ix86_expand_pextr): Reject extractions from misaligned positions. (ix86_expand_pinsr): Reject insertions to misaligned positions. testsuite/ChangeLog: PR target/66922 * gcc.target/i386/pr66922.c: New test. From-SVN: r225980 --- gcc/ChangeLog | 7 +++++++ gcc/config/i386/i386.c | 8 ++++++++ gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.target/i386/pr66922.c | 23 +++++++++++++++++++++++ 4 files changed, 43 insertions(+) create mode 100644 gcc/testsuite/gcc.target/i386/pr66922.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 98fb37bb2a8..095713d9dff 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2015-07-18 Uros Bizjak + + PR target/66922 + * config/i386/i386.c (ix86_expand_pextr): Reject extractions + from misaligned positions. + (ix86_expand_pinsr): Reject insertions to misaligned positions. + 2015-07-18 Sebastian Pop PR middle-end/46851 diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c index 01a1cb94a7c..7901a4f17d7 100644 --- a/gcc/config/i386/i386.c +++ b/gcc/config/i386/i386.c @@ -50591,6 +50591,10 @@ ix86_expand_pextr (rtx *operands) return false; } + /* Reject extractions from misaligned positions. */ + if (pos & (size-1)) + return false; + if (GET_MODE (dst) == dstmode) d = dst; else @@ -50687,6 +50691,10 @@ ix86_expand_pinsr (rtx *operands) return false; } + /* Reject insertions to misaligned positions. */ + if (pos & (size-1)) + return false; + if (GET_CODE (src) == SUBREG) { unsigned int srcpos = SUBREG_BYTE (src); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index a9b34ba71f1..214ad673d89 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2015-07-18 Uros Bizjak + + PR target/66922 + * gcc.target/i386/pr66922.c: New test. + 2015-07-18 Sebastian Pop PR middle-end/46851 diff --git a/gcc/testsuite/gcc.target/i386/pr66922.c b/gcc/testsuite/gcc.target/i386/pr66922.c new file mode 100644 index 00000000000..46274b22ce8 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr66922.c @@ -0,0 +1,23 @@ +/* { dg-do run } */ +/* { dg-options "-O1 -msse2" } */ +/* { dg-require-effective-target sse2 } */ + +#include "sse2-check.h" + +struct S +{ + int:31; + int:2; + int f0:16; + int f1; + int f2; +}; + +static void +sse2_test (void) +{ + struct S a = { 1, 0, 0 }; + + if (a.f0 != 1) + __builtin_abort(); +} -- 2.30.2