From ac05557cc7402b73c098179049cad48da07c52dc Mon Sep 17 00:00:00 2001 From: Daniel Franke Date: Wed, 19 Mar 2008 15:13:48 -0400 Subject: [PATCH] re PR fortran/35152 (Implicit procedure with keyword=argument is accepted) gcc/fortran: 2008-03-19 Daniel Franke PR fortran/35152 * interface.c (gfc_procedure_use): Check for keyworded arguments in procedures without explicit interfaces. gcc/testsuite: 2008-03-19 Daniel Franke PR fortran/35152 * gfortran.dg/argument_checking_16.f90: New test. From-SVN: r133347 --- gcc/fortran/ChangeLog | 6 +++++ gcc/fortran/interface.c | 23 ++++++++++++++++--- gcc/testsuite/ChangeLog | 5 ++++ .../gfortran.dg/argument_checking_16.f90 | 9 ++++++++ 4 files changed, 40 insertions(+), 3 deletions(-) create mode 100644 gcc/testsuite/gfortran.dg/argument_checking_16.f90 diff --git a/gcc/fortran/ChangeLog b/gcc/fortran/ChangeLog index 08f1a8c2c26..9254562afae 100644 --- a/gcc/fortran/ChangeLog +++ b/gcc/fortran/ChangeLog @@ -1,3 +1,9 @@ +2008-03-19 Daniel Franke + + PR fortran/35152 + * interface.c (gfc_procedure_use): Check for keyworded arguments in + procedures without explicit interfaces. + 2008-03-16 Paul Thomas PR fortran/35470 diff --git a/gcc/fortran/interface.c b/gcc/fortran/interface.c index 4cee386d3d5..09f72383b0f 100644 --- a/gcc/fortran/interface.c +++ b/gcc/fortran/interface.c @@ -2419,9 +2419,26 @@ gfc_procedure_use (gfc_symbol *sym, gfc_actual_arglist **ap, locus *where) } } - if (sym->attr.if_source == IFSRC_UNKNOWN - || !compare_actual_formal (ap, sym->formal, 0, - sym->attr.elemental, where)) + if (sym->attr.external + || sym->attr.if_source == IFSRC_UNKNOWN) + { + gfc_actual_arglist *a; + for (a = *ap; a; a = a->next) + { + /* Skip g77 keyword extensions like %VAL, %REF, %LOC. */ + if (a->name != NULL && a->name[0] != '%') + { + gfc_error("Keyword argument requires explicit interface " + "for procedure '%s' at %L", sym->name, &a->expr->where); + break; + } + } + + return; + } + + if (!compare_actual_formal (ap, sym->formal, 0, + sym->attr.elemental, where)) return; check_intents (sym->formal, *ap); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 0781ed5e4be..6557c0cafb1 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2008-03-19 Daniel Franke + + PR fortran/35152 + * gfortran.dg/argument_checking_16.f90: New test. + 2008-03-19 Thomas Koenig PR libfortran/32972 diff --git a/gcc/testsuite/gfortran.dg/argument_checking_16.f90 b/gcc/testsuite/gfortran.dg/argument_checking_16.f90 new file mode 100644 index 00000000000..75b2eced122 --- /dev/null +++ b/gcc/testsuite/gfortran.dg/argument_checking_16.f90 @@ -0,0 +1,9 @@ +! { dg-do compile } +! PR fortran/35152 - implicit procedure with keyword=argument + +external bar + +call bar(a=5) ! { dg-error "requires explicit interface" } +call foo(a=5) ! { dg-error "requires explicit interface" } +end + -- 2.30.2