From ac2551850669c3013b1b6e142a167060328ff52d Mon Sep 17 00:00:00 2001 From: Claudiu Zissulescu Date: Mon, 27 Mar 2017 12:56:14 +0200 Subject: [PATCH] [ARC] Fix detection of long immediate for load/store operands. ARC can use scaled offsets when loading (i.e. ld.as rA,[base, offset]). Where base and offset can be a register or an immediate operand. The scaling only applies on the offset part of the instruction. The compiler can accept an address like this: (plus:SI (mult:SI (reg:SI 2 r2 [orig:596 _2129 ] [596]) (const_int 4 [0x4])) (const_int 60 [0x3c])) Hence, to emit this instruction we place the (const_int 60) into base and the register into offset to take advantage of the scaled offset facility of the load instruction. As a result the length of the load instruction is 8 bytes. However, the long_immediate_loadstore_operand predicate used for calculating the length attribute doesn't recognize this address and returns a wrong decision leading to a wrong length computation for a load instruction using the above address. gcc/ 2017-03-27 Claudiu Zissulescu * config/arc/predicates.md (long_immediate_loadstore_operand): Consider scaled addresses cases. From-SVN: r246496 --- gcc/ChangeLog | 5 +++++ gcc/config/arc/predicates.md | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 336fa7fedf1..598f03d42cc 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2017-03-27 Claudiu Zissulescu + + * config/arc/predicates.md (long_immediate_loadstore_operand): + Consider scaled addresses cases. + 2017-03-27 Claudiu Zissulescu * config/arc/arc.c (arc_epilogue_uses): BLINK should be also diff --git a/gcc/config/arc/predicates.md b/gcc/config/arc/predicates.md index 0dec736be5f..8dd8d558b9e 100644 --- a/gcc/config/arc/predicates.md +++ b/gcc/config/arc/predicates.md @@ -148,6 +148,11 @@ { rtx x = XEXP (op, 1); + if ((GET_CODE (XEXP (op, 0)) == MULT) + && REG_P (XEXP (XEXP (op, 0), 0)) + && CONSTANT_P (x)) + return 1; + if (GET_CODE (x) == CONST) { x = XEXP (x, 0); -- 2.30.2