From acad54cf4e01809170e343b13f302fc5b032c366 Mon Sep 17 00:00:00 2001 From: Ciro Santilli Date: Tue, 6 Aug 2019 16:17:51 +0100 Subject: [PATCH] base: assert that stats bucket size is greater than 0 Change-Id: I9a2264e9ee74acea1f09f01ea8f5004567ba1ea8 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/20049 Reviewed-by: Jason Lowe-Power Reviewed-by: Anthony Gutierrez Maintainer: Anthony Gutierrez Tested-by: kokoro --- src/base/statistics.hh | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/base/statistics.hh b/src/base/statistics.hh index 69a2afffc..6ddf7ff17 100644 --- a/src/base/statistics.hh +++ b/src/base/statistics.hh @@ -2533,6 +2533,9 @@ class Distribution : public DistBase params->min = min; params->max = max; params->bucket_size = bkt; + // Division by zero is especially serious in an Aarch64 host, + // where it gets rounded to allocate 32GiB RAM. + assert(bkt > 0); params->buckets = (size_type)ceil((max - min + 1.0) / bkt); this->setParams(params); this->doInit(); -- 2.30.2