From ad9eb1fdda263cd91ee8fb36292fb29d546b0076 Mon Sep 17 00:00:00 2001 From: Doug Evans Date: Mon, 7 Nov 2016 13:27:22 -0800 Subject: [PATCH] i386-tdep.c (i386_gdbarch_init): Add comments. gdb/ChangeLog: * i386-tdep.c (i386_gdbarch_init): Add comments. --- gdb/ChangeLog | 4 ++++ gdb/i386-tdep.c | 8 ++++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index dd9f8cb383c..f4f6fd51487 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2016-11-07 Doug Evans + + * i386-tdep.c (i386_gdbarch_init): Add comments. + 2016-11-07 Doug Evans * python/py-unwind.c (unwind_infopy_str): Fix use of VEC_iterate. diff --git a/gdb/i386-tdep.c b/gdb/i386-tdep.c index a67eca00164..22fb54cea03 100644 --- a/gdb/i386-tdep.c +++ b/gdb/i386-tdep.c @@ -8316,6 +8316,8 @@ i386_validate_tdesc_p (struct gdbarch_tdep *tdep, } +/* Note: This is called for both i386 and amd64. */ + static struct gdbarch * i386_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) { @@ -8333,7 +8335,7 @@ i386_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) if (arches != NULL) return arches->gdbarch; - /* Allocate space for the new architecture. */ + /* Allocate space for the new architecture. Assume i386 for now. */ tdep = XCNEW (struct gdbarch_tdep); gdbarch = gdbarch_alloc (&info, tdep); @@ -8560,7 +8562,9 @@ i386_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) set_gdbarch_insn_is_ret (gdbarch, i386_insn_is_ret); set_gdbarch_insn_is_jump (gdbarch, i386_insn_is_jump); - /* Hook in ABI-specific overrides, if they have been registered. */ + /* Hook in ABI-specific overrides, if they have been registered. + Note: If INFO specifies a 64 bit arch, this is where we turn + a 32-bit i386 into a 64-bit amd64. */ info.tdep_info = tdesc_data; gdbarch_init_osabi (info, gdbarch); -- 2.30.2