From ae2bfab7b73a1cc2e75f3cbe9a1407e78a23de90 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Wed, 19 Jun 2019 09:24:01 -0700 Subject: [PATCH] panfrost/decode: Clip mali_compute_fbd at 64-bytes Looking at internal evidence (later fields including a literal other compute job inception-style, seeming memory corruption, no clear function, and the field after this being a pointer to *itself*), it looks like this is really a much smaller descriptor. Signed-off-by: Alyssa Rosenzweig --- src/gallium/drivers/panfrost/include/panfrost-job.h | 9 --------- src/gallium/drivers/panfrost/pandecode/decode.c | 9 --------- 2 files changed, 18 deletions(-) diff --git a/src/gallium/drivers/panfrost/include/panfrost-job.h b/src/gallium/drivers/panfrost/include/panfrost-job.h index aaf6de72bc6..6da86148cd7 100644 --- a/src/gallium/drivers/panfrost/include/panfrost-job.h +++ b/src/gallium/drivers/panfrost/include/panfrost-job.h @@ -1411,15 +1411,6 @@ struct mali_single_framebuffer { struct mali_compute_fbd { u32 unknown1[16]; - mali_ptr unknown2; - mali_ptr unknown3; - u32 unknown4[16]; - u32 unknown5[18]; - mali_ptr unknown6; - u32 unknown7[4]; - mali_ptr unknown8; - mali_ptr unknown9; - u32 unknown10[16]; } __attribute__((packed)); /* Format bits for the render target flags */ diff --git a/src/gallium/drivers/panfrost/pandecode/decode.c b/src/gallium/drivers/panfrost/pandecode/decode.c index c402ff91cbc..8adcb5a7d44 100644 --- a/src/gallium/drivers/panfrost/pandecode/decode.c +++ b/src/gallium/drivers/panfrost/pandecode/decode.c @@ -563,15 +563,6 @@ pandecode_compute_fbd(uint64_t gpu_va, int job_no) pandecode_indent++; SHORT_SLIDE(1); - MEMORY_PROP(s, unknown2); - MEMORY_PROP(s, unknown3); - SHORT_SLIDE(4); - SHORT_SLIDE(5); - MEMORY_PROP(s, unknown6); - SHORT_SLIDE(7); - MEMORY_PROP(s, unknown8); - MEMORY_PROP(s, unknown9); - SHORT_SLIDE(10); pandecode_indent--; printf("},\n"); -- 2.30.2