From aeca22f97c5650108a315063ea76ad2204bb2ef5 Mon Sep 17 00:00:00 2001 From: Keith Packard Date: Thu, 6 Dec 2007 14:11:34 -0800 Subject: [PATCH] Use previous buffer offsets to compute proposed relocations This takes advantage of the DRM_BO_HINT_PRESUMED_OFFSET change and allows the kernel to avoid mapping and re-writing buffers when relocations occur. --- .../drivers/dri/intel/intel_batchbuffer.c | 7 +++++- src/mesa/drivers/dri/intel/intel_bufmgr_ttm.c | 22 +++++++++++++++++++ 2 files changed, 28 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/intel/intel_batchbuffer.c b/src/mesa/drivers/dri/intel/intel_batchbuffer.c index 21db0e7dcd6..1deca8ca1d5 100644 --- a/src/mesa/drivers/dri/intel/intel_batchbuffer.c +++ b/src/mesa/drivers/dri/intel/intel_batchbuffer.c @@ -246,7 +246,12 @@ intel_batchbuffer_emit_reloc(struct intel_batchbuffer *batch, GLuint flags, GLuint delta) { dri_emit_reloc(batch->buf, flags, delta, batch->ptr - batch->map, buffer); - batch->ptr += 4; + /* + * Using the old buffer offset, write in what the right data would be, in case + * the buffer doesn't move and we can short-circuit the relocation processing + * in the kernel + */ + intel_batchbuffer_emit_dword (batch, buffer->offset + delta); return GL_TRUE; } diff --git a/src/mesa/drivers/dri/intel/intel_bufmgr_ttm.c b/src/mesa/drivers/dri/intel/intel_bufmgr_ttm.c index 3e0d818a0cc..ab52efca372 100644 --- a/src/mesa/drivers/dri/intel/intel_bufmgr_ttm.c +++ b/src/mesa/drivers/dri/intel/intel_bufmgr_ttm.c @@ -193,6 +193,10 @@ intel_setup_validate_list(dri_bufmgr_ttm *bufmgr_ttm, GLuint *count_p) req->op = drm_bo_validate; req->bo_req.flags = node->flags; req->bo_req.hint = 0; +#ifdef DRM_BO_HINT_PRESUMED_OFFSET + req->bo_req.hint |= DRM_BO_HINT_PRESUMED_OFFSET; + req->bo_req.presumed_offset = ((dri_bo *) node->priv)->offset; +#endif req->bo_req.mask = node->mask; req->bo_req.fence_class = 0; /* Backwards compat. */ arg->reloc_handle = 0; @@ -838,11 +842,29 @@ dri_ttm_process_reloc(dri_bo *batch_buf, GLuint *count) return ptr; } +static void +intel_update_buffer_offsets (dri_bufmgr_ttm *bufmgr_ttm) +{ + struct intel_bo_list *list = &bufmgr_ttm->list; + struct intel_bo_node *node; + drmMMListHead *l; + struct drm_i915_op_arg *arg; + struct drm_bo_arg_rep *rep; + + for (l = list->list.next; l != &list->list; l = l->next) { + node = DRMLISTENTRY(struct intel_bo_node, l, head); + arg = &node->bo_arg; + rep = &arg->d.rep; + ((dri_bo *) node->priv)->offset = rep->bo_info.offset; + } +} + static void dri_ttm_post_submit(dri_bo *batch_buf, dri_fence **last_fence) { dri_bufmgr_ttm *bufmgr_ttm = (dri_bufmgr_ttm *)batch_buf->bufmgr; + intel_update_buffer_offsets (bufmgr_ttm); intel_free_validate_list(bufmgr_ttm); intel_free_reloc_list(bufmgr_ttm); -- 2.30.2