From aef1ba5ce4fe2c2359d2927f209107853440bb5a Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Sat, 3 Nov 2018 07:24:54 -0700 Subject: [PATCH] iris: fix overhead regression from "don't stomp each other's dirty bits" The change from dirty = 0ull to dirty &= ~NOT_MY_BITS broke the "nothing to do? skip it!" optimization. thanks to Chris for noticing this! --- src/gallium/drivers/iris/iris_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/iris/iris_state.c b/src/gallium/drivers/iris/iris_state.c index be7ca83d4b3..859c96717bc 100644 --- a/src/gallium/drivers/iris/iris_state.c +++ b/src/gallium/drivers/iris/iris_state.c @@ -3766,7 +3766,7 @@ iris_upload_dirty_render_state(struct iris_context *ice, { const uint64_t dirty = ice->state.dirty; - if (!dirty) + if (!(dirty & IRIS_ALL_DIRTY_FOR_RENDER)) return; struct iris_genx_state *genx = ice->state.genx; -- 2.30.2