From af552cd02f23d3aa90268f0d91008545d4d8ddd2 Mon Sep 17 00:00:00 2001 From: Bob Duff Date: Wed, 18 Dec 2019 07:14:13 +0000 Subject: [PATCH] [Ada] Wrong error on hidden must-override primitive 2019-12-18 Bob Duff gcc/ada/ * sem_ch3.adb (Derive_Subprogram): Do not set the Requires_Overriding flag in the above-mentioned case. From-SVN: r279505 --- gcc/ada/ChangeLog | 5 +++++ gcc/ada/sem_ch3.adb | 13 +++++++++++-- 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/gcc/ada/ChangeLog b/gcc/ada/ChangeLog index 36e5d00b2e8..6f6caf45642 100644 --- a/gcc/ada/ChangeLog +++ b/gcc/ada/ChangeLog @@ -1,3 +1,8 @@ +2019-12-18 Bob Duff + + * sem_ch3.adb (Derive_Subprogram): Do not set the + Requires_Overriding flag in the above-mentioned case. + 2019-12-18 Bob Duff * sem_ch8.adb (Note_Redundant_Use): It was already checking for diff --git a/gcc/ada/sem_ch3.adb b/gcc/ada/sem_ch3.adb index ca2247671e1..956c92ddfe2 100644 --- a/gcc/ada/sem_ch3.adb +++ b/gcc/ada/sem_ch3.adb @@ -15606,7 +15606,8 @@ package body Sem_Ch3 is Set_Derived_Name; -- Otherwise, the type is inheriting a private operation, so enter it - -- with a special name so it can't be overridden. + -- with a special name so it can't be overridden. See also below, where + -- we check for this case, and if so avoid setting Requires_Overriding. else Set_Chars (New_Subp, New_External_Name (Chars (Parent_Subp), 'P')); @@ -15786,7 +15787,15 @@ package body Sem_Ch3 is or else Is_Abstract_Subprogram (Alias (New_Subp)) then Set_Is_Abstract_Subprogram (New_Subp); - else + + -- If the Chars of the new subprogram is different from that of the + -- parent's one, it means that we entered it with a special name so + -- it can't be overridden (see above). In that case we had better not + -- *require* it to be overridden. This is the case where the parent + -- type inherited the operation privately, so there's no danger of + -- dangling dispatching. + + elsif Chars (New_Subp) = Chars (Alias (New_Subp)) then Set_Requires_Overriding (New_Subp); end if; -- 2.30.2