From af7bf610cf74c6805f42babbcf85bc88b2b9453d Mon Sep 17 00:00:00 2001 From: Dave Airlie Date: Thu, 2 Jun 2016 14:13:18 +1000 Subject: [PATCH] mesa/copyimage: report INVALID_VALUE for missing cube face The specs says INVALID_VALUE for exceeding dimensions, which is really what is happening here. This fixes: GL45-CTS.copy_image.non_existent_mipmap Cc: "11.2 12.0" Reviewed-by: Antia Puentes Signed-off-by: Dave Airlie --- src/mesa/main/copyimage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/copyimage.c b/src/mesa/main/copyimage.c index 6aa6bcb973a..7e5df61682a 100644 --- a/src/mesa/main/copyimage.c +++ b/src/mesa/main/copyimage.c @@ -180,7 +180,7 @@ prepare_target(struct gl_context *ctx, GLuint name, GLenum target, for (i = 0; i < depth; i++) { if (!texObj->Image[z+i][level]) { /* missing cube face */ - _mesa_error(ctx, GL_INVALID_OPERATION, + _mesa_error(ctx, GL_INVALID_VALUE, "glCopyImageSubData(missing cube face)"); return false; } -- 2.30.2