From afb6bc67a6e3a9fa08a61d81e17e0c152ed09f2a Mon Sep 17 00:00:00 2001 From: "Yann E. MORIN" Date: Thu, 10 Aug 2017 23:51:11 +0200 Subject: [PATCH] package/valgrind: hide comment when arch is not supported MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Currently, the comment that "valgrind needs shared libs" is not hidden when the architecture dependencies are not met, which can confuse some users (as recently seen on IRC). Fix that by introducing the traditional _ARCH_SUPPORTS option, and have the comment and the symbol depend on that. Signed-off-by: "Yann E. MORIN" Cc: Brandon Maier Cc: Jérôme Pouiller Cc: Peter Seiderer Cc: Thomas Petazzoni Cc: Vicente Olivert Riera Reviewed--by: Pedro Ribeiro Tested-by: Pedro Ribeiro [Arnout: put _ARCH_SUPPORTS at the top of the file] Signed-off-by: Arnout Vandecappelle (Essensium/Mind) --- package/valgrind/Config.in | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/package/valgrind/Config.in b/package/valgrind/Config.in index 40e219d95a..75b779d214 100644 --- a/package/valgrind/Config.in +++ b/package/valgrind/Config.in @@ -1,14 +1,19 @@ +config BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS + bool + default y if BR2_ARM_CPU_ARMV7A + default y if BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el + default y if BR2_i386 || BR2_x86_64 + default y if BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le + depends on !BR2_MIPS_SOFT_FLOAT + comment "valgrind needs a toolchain w/ dynamic library" + depends on BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS depends on BR2_STATIC_LIBS config BR2_PACKAGE_VALGRIND bool "valgrind" - depends on BR2_ARM_CPU_ARMV7A || BR2_i386 || \ - BR2_mips || BR2_mipsel || BR2_mips64 || BR2_mips64el || \ - BR2_powerpc || BR2_powerpc64 || BR2_powerpc64le || \ - BR2_x86_64 + depends on BR2_PACKAGE_VALGRIND_ARCH_SUPPORTS depends on !BR2_STATIC_LIBS - depends on !BR2_MIPS_SOFT_FLOAT help Tool for debugging and profiling Linux programs. -- 2.30.2