From afda45a206f83389782a400f86668714400a1cb7 Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Fri, 14 Jun 2019 21:57:42 +0100 Subject: [PATCH] gdb: Remove unused parameter The parameter 'fullname' is always passed as NULL to the function get_filename_and_charpos in source.c, so lets remove the parameter. There should be no user visible changes after this commit. gdb/ChangeLog: * source.c (get_filename_and_charpos): Remove fullname parameter. (identify_source_line): Update call to get_filename_and_charpos. --- gdb/ChangeLog | 6 ++++++ gdb/source.c | 12 +++--------- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 702aa7fea4a..83916efc630 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2019-06-15 Andrew Burgess + + * source.c (get_filename_and_charpos): Remove fullname + parameter. + (identify_source_line): Update call to get_filename_and_charpos. + 2019-06-14 Tom Tromey PR gdb/24502: diff --git a/gdb/source.c b/gdb/source.c index 02df15a1ae6..5fa55e2c160 100644 --- a/gdb/source.c +++ b/gdb/source.c @@ -1201,17 +1201,11 @@ find_source_lines (struct symtab *s, int desc) or to 0 if the file is not found. */ static void -get_filename_and_charpos (struct symtab *s, char **fullname) +get_filename_and_charpos (struct symtab *s) { scoped_fd desc = open_source_file (s); if (desc.get () < 0) - { - if (fullname) - *fullname = NULL; - return; - } - if (fullname) - *fullname = s->fullname; + return; if (s->line_charpos == 0) find_source_lines (s, desc.get ()); } @@ -1223,7 +1217,7 @@ identify_source_line (struct symtab *s, int line, int mid_statement, CORE_ADDR pc) { if (s->line_charpos == 0) - get_filename_and_charpos (s, (char **) NULL); + get_filename_and_charpos (s); if (s->fullname == 0) return 0; if (line > s->nlines) -- 2.30.2