From b0af93ad2ba7db505e5967aeebe37f88b17e44cf Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Mon, 27 Mar 2023 17:40:06 +0200 Subject: [PATCH] [gdb/testsuite] Skip do_self_tests on remote host In do_self_tests we try to find out the location of the gdb to debug, which will then be copied and renamed to xgdb. In principle, the host board specifies the location of GDB, on host. With remote host, we could upload that gdb from host to build/target, but we would miss the data directory (which is listed as the reason to skip do_self_tests for remote target). We could fix that by instead taking the gdb from build instead, but that wouldn't work with installed testing. It seems easier to just skip this on remote host. It could be made to work for the "[is_remote host] && [is_remote target] && host == target" scenario (see board local-remote-host-native.exp), but that doesn't seem worth the effort. Tested on x86_64-linux. --- gdb/testsuite/lib/selftest-support.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/lib/selftest-support.exp b/gdb/testsuite/lib/selftest-support.exp index 61379f59bb4..1e7a2cea8b7 100644 --- a/gdb/testsuite/lib/selftest-support.exp +++ b/gdb/testsuite/lib/selftest-support.exp @@ -100,7 +100,7 @@ proc do_self_tests {function body} { # Are we testing with a remote board? In that case, the target # won't have access to the GDB's auxilliary data files # (data-directory, etc.). It's simpler to just skip. - if [is_remote target] { + if { [is_remote target] || [is_remote host] } { return } -- 2.30.2