From b0fead2b6ccb66d9992c06414159ddad063e2d6d Mon Sep 17 00:00:00 2001 From: Richard Earnshaw Date: Fri, 8 Sep 2006 10:30:27 +0000 Subject: [PATCH] 2006-09-08 Vladimir Prus * elf32-arm.c (elf32_arm_swap_symbol_out): Remove unconditional setting of low bit for Thumb symbol mistakenly left behind after check for external symbols was added. Fix comment typo. --- bfd/ChangeLog | 7 +++++++ bfd/elf32-arm.c | 4 +--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 88cff5c8b83..fd79708af3d 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,10 @@ +2006-09-08 Vladimir Prus + + * elf32-arm.c (elf32_arm_swap_symbol_out): Remove + unconditional setting of low bit for Thumb symbol + mistakenly left behind after check for external + symbols was added. Fix comment typo. + 2006-09-07 H.J. Lu * elf-bfd.h (elf_link_hash_entry): Add a dynamic field. diff --git a/bfd/elf32-arm.c b/bfd/elf32-arm.c index 530ef998734..8db3c8cb2fd 100644 --- a/bfd/elf32-arm.c +++ b/bfd/elf32-arm.c @@ -9385,14 +9385,12 @@ elf32_arm_swap_symbol_out (bfd *abfd, linker will simulate the work of dynamic linker of resolving symbols and will carry over the thumbness of found symbols to the output symbol table. It's not clear how it happens, but - the thumbness of underfined symbols can well be different at + the thumbness of undefined symbols can well be different at runtime, and writing '1' for them will be confusing for users and possibly for dynamic linker itself. */ newsym.st_value |= 1; } - - newsym.st_value |= 1; src = &newsym; } -- 2.30.2