From b13057d9ceaa4944dc2d0ebf5df750d9350d0727 Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Tue, 30 Jul 2019 09:42:07 +0200 Subject: [PATCH] [gdb/testsuite] Fail in gdb_compile if nopie results in PIE executable When running gdb.base/dump.exp with --target_board=unix/-fPIE/-pie, we get: ... Running gdb/testsuite/gdb.base/dump.exp ... FAIL: gdb.base/dump.exp: dump array as value, intel hex ... The FAIL happens because although the test specifies nopie, the exec is in fact compiled as PIE. The "-fPIE -pie" options specified using the target_board are interpreted by dejagnu as multilib_flags, and end up overriding the nopie flags. Fix this by checking in gdb_compile if the resulting exec is PIE despite of a nopie setting, and if so return an error: ... Running gdb/testsuite/gdb.base/dump.exp ... gdb compile failed, nopie failed to prevent PIE executable === gdb Summary === nr of untested testcases 1 ... Tested on x86_64-linux. gdb/testsuite/ChangeLog: 2019-07-30 Tom de Vries PR testsuite/24834 * lib/gdb.exp (gdb_compile): Fail if nopie results in PIE executable. (exec_is_pie): New proc. --- gdb/testsuite/ChangeLog | 6 ++++++ gdb/testsuite/lib/gdb.exp | 18 ++++++++++++++++++ 2 files changed, 24 insertions(+) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index b2551063fe8..3476d7f46f2 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,9 @@ +2019-07-30 Tom de Vries + + PR testsuite/24834 + * lib/gdb.exp (gdb_compile): Fail if nopie results in PIE executable. + (exec_is_pie): New proc. + 2019-07-29 Christian Biesinger * gdb.python/py-objfile.c: Add global and static vars. diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp index 14b9601122b..68e94346dee 100644 --- a/gdb/testsuite/lib/gdb.exp +++ b/gdb/testsuite/lib/gdb.exp @@ -3771,6 +3771,12 @@ proc gdb_compile {source dest type options} { regsub "\[\r\n\]*$" "$result" "" result regsub "^\[\r\n\]*" "$result" "" result + if { $type == "executable" && $result == "" && $nopie != -1 } { + if { [exec_is_pie "$dest"] } { + set result "nopie failed to prevent PIE executable" + } + } + if {[lsearch $options quiet] < 0} { # We shall update this on a per language basis, to avoid # changing the entire testsuite in one go. @@ -5171,6 +5177,18 @@ proc exec_has_index_section { executable } { return 0 } +# Return true if EXECUTABLE is a Position Independent Executable. + +proc exec_is_pie { executable } { + set readelf_program [gdb_find_readelf] + set res [catch {exec $readelf_program -d $executable \ + | grep -E "(FLAGS_1).*Flags:.* PIE($| )" }] + if { $res == 0 } { + return 1 + } + return 0 +} + # Return true if a test should be skipped due to lack of floating # point support or GDB can't fetch the contents from floating point # registers. -- 2.30.2