From b1b07054c08eea65ba8d1a9f771796d686f337e5 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Tue, 7 Mar 2017 11:04:19 +1030 Subject: [PATCH] PowerPC64 abort due to dynamic relocs on hidden undefweak ppc64_elf_relocate_section lacked a check which meant that it emitted dynamic relocs against a hidden undefweak symbol for which no dynamic relocs had been allocated. PR 21224 PR 20519 * elf64-ppc.c (ppc64_elf_relocate_section): Add missing dyn_relocs check. --- bfd/ChangeLog | 7 +++++++ bfd/elf64-ppc.c | 6 ++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 92682d56b9c..9560ad2e7a7 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,10 @@ +2017-03-07 Alan Modra + + PR 21224 + PR 20519 + * elf64-ppc.c (ppc64_elf_relocate_section): Add missing + dyn_relocs check. + 2017-03-05 Alan Modra * elf-bfd.h (struct eh_cie_fde): Add u.cie.per_encoding_aligned8. diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c index 84cb2140872..d0673c91878 100644 --- a/bfd/elf64-ppc.c +++ b/bfd/elf64-ppc.c @@ -14804,8 +14804,10 @@ ppc64_elf_relocate_section (bfd *output_bfd, break; if (bfd_link_pic (info) - ? ((h != NULL && pc_dynrelocs (h)) - || must_be_dyn_reloc (info, r_type)) + ? ((h == NULL + || h->dyn_relocs != NULL) + && ((h != NULL && pc_dynrelocs (h)) + || must_be_dyn_reloc (info, r_type))) : (h != NULL ? h->dyn_relocs != NULL : ELF_ST_TYPE (sym->st_info) == STT_GNU_IFUNC)) -- 2.30.2