From b1b189e04cb5ea5da1cbb07bd6cceccd4d2ac969 Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Sat, 20 Jan 2018 23:56:37 +0000 Subject: [PATCH] gdb: Add test for some error cases of @entry usage Adds a test that using @entry for a non-parameter, or for an unknown symbol, both give the expected error. This error message was previously untested. gdb/testsuite/ChangeLog: * gdb.arch/amd64-entry-value.exp: Test using @entry on a non-parameter, and on an unknown symbol. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.arch/amd64-entry-value.exp | 8 ++++++++ 2 files changed, 13 insertions(+) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 2b968010fd5..db860b0a1f8 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2018-01-21 Andrew Burgess + + * gdb.arch/amd64-entry-value.exp: Test using @entry on a + non-parameter, and on an unknown symbol. + 2018-01-19 Tom Tromey * gdb.rust/modules.rs (TWENTY_THREE): New global. diff --git a/gdb/testsuite/gdb.arch/amd64-entry-value.exp b/gdb/testsuite/gdb.arch/amd64-entry-value.exp index 46a896fdec0..72700d55c23 100644 --- a/gdb/testsuite/gdb.arch/amd64-entry-value.exp +++ b/gdb/testsuite/gdb.arch/amd64-entry-value.exp @@ -87,6 +87,14 @@ gdb_test "p d9@entry" " = 11\\.5" "entry_stack: p d9@entry" gdb_test "p da" " = 4\\.5" "entry_stack: p da" gdb_test "p da@entry" " = 12\\.5" "entry_stack: p da@entry" +# Test @entry values for a static file scoped variable, and for an +# unknown symbol. Both of these should give an error. +gdb_test "p v@entry" \ + "@entry can be used only for function parameters, not for \"v\"" \ + "attempt to print global v@entry" +gdb_test "p unknown@entry" \ + "@entry can be used only for function parameters, not for \"unknown\"" \ + "attempt to print unknown@entry" # Test various kinds of `set print entry-values'. -- 2.30.2