From b230d51a181aae0982d167e227d1833154133a5c Mon Sep 17 00:00:00 2001 From: Dave Airlie Date: Tue, 10 May 2016 15:41:46 +1000 Subject: [PATCH] mesa/meta: check for signed/unsigned int conversion for pbo getteximage When doing GetTexSubImage using a PBO, we should check if it involves a signed/unsigned conversion and bail if it does, just like in the other cases. This fixes: GL33-CTS.gtf32.GL3Tests.packed_pixels.packed_pixels_pbo on Haswell at least. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=95324 Reviewed-by: Matt Turer Cc: mesa-stable@lists.freedesktop.org Signed-off-by: Dave Airlie --- src/mesa/drivers/common/meta_tex_subimage.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/common/meta_tex_subimage.c b/src/mesa/drivers/common/meta_tex_subimage.c index 62c3fce4249..988af91ce4e 100644 --- a/src/mesa/drivers/common/meta_tex_subimage.c +++ b/src/mesa/drivers/common/meta_tex_subimage.c @@ -355,6 +355,9 @@ _mesa_meta_pbo_GetTexSubImage(struct gl_context *ctx, GLuint dims, */ if (need_signed_unsigned_int_conversion(rb->Format, format, type)) return false; + } else { + if (need_signed_unsigned_int_conversion(tex_image->TexFormat, format, type)) + return false; } /* For arrays, use a tall (height * depth) 2D texture but taking into -- 2.30.2