From b3a5b1fd71079ffb01b4969b34e11fd6c5d416f6 Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Fri, 14 Oct 2022 13:09:51 +0200 Subject: [PATCH] [gdb/testsuite] Drop unnecessary -Wl,-soname in gdb.base/skip-solib.exp I noticed in gdb.base/skip-solib.exp: ... if {[gdb_compile_shlib ${srcdir}/${subdir}/${srcfile_lib} ${binfile_lib} \ [list debug -Wl,-soname,${libname}.so]] != ""} { return -1 } ... that the -Wl,-soname argument is missing an ldflags= prefix, but adding it gives us a duplicate: ... Executing on host: gcc -fno-stack-protector \ outputs/gdb.base/skip-solib/skip-solib-lib.c.o -fdiagnostics-color=never \ -shared -g -Wl,-soname,libskip-solib.so -Wl,-soname,libskip-solib.so -lm \ -o outputs/gdb.base/skip-solib/libskip-solib.so (timeout = 300) ... so apparently it's taken care of by gdb_compile_shlib. Drop the inactive and also unnecessary -Wl,-soname,${libname}.so from the flags list for the gdb_compile_shlib call. Tested on x86_64-linux. --- gdb/testsuite/gdb.base/skip-solib.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/skip-solib.exp b/gdb/testsuite/gdb.base/skip-solib.exp index 9af39d829c0..49539bb6695 100644 --- a/gdb/testsuite/gdb.base/skip-solib.exp +++ b/gdb/testsuite/gdb.base/skip-solib.exp @@ -41,7 +41,7 @@ set binfile_lib [standard_output_file ${libname}.so] # if {[gdb_compile_shlib ${srcdir}/${subdir}/${srcfile_lib} ${binfile_lib} \ - [list debug -Wl,-soname,${libname}.so]] != ""} { + [list debug]] != ""} { return -1 } -- 2.30.2