From b3b3227982613ac926b58b84e16867624ae0ed04 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Sat, 8 Feb 2020 13:40:54 -0700 Subject: [PATCH] Minor simplification in abbrev_table::read abbrev_table::read increments cur_abbrev->num_attrs in the inner loop, but there's no need to do this, as the information is already stored in the temporary vector. 2020-02-08 Tom Tromey * dwarf2/abbrev.c (abbrev_table::read): Simplify. Change-Id: I765f12850ffa1c6066e884bb22c94468d1abdba4 --- gdb/ChangeLog | 4 ++++ gdb/dwarf2/abbrev.c | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index ab208775b6c..2dc3a7c8dc9 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2020-02-08 Tom Tromey + + * dwarf2/abbrev.c (abbrev_table::read): Simplify. + 2020-02-08 Tom Tromey * dwarf2/abbrev.c (abbrev_table): Move constructor from header. diff --git a/gdb/dwarf2/abbrev.c b/gdb/dwarf2/abbrev.c index f843e32d950..59ff138b33d 100644 --- a/gdb/dwarf2/abbrev.c +++ b/gdb/dwarf2/abbrev.c @@ -162,9 +162,9 @@ abbrev_table::read (struct objfile *objfile, cur_attr.name = (enum dwarf_attribute) abbrev_name; cur_attr.form = (enum dwarf_form) abbrev_form; cur_attr.implicit_const = implicit_const; - ++cur_abbrev->num_attrs; } + cur_abbrev->num_attrs = cur_attrs.size (); cur_abbrev->attrs = XOBNEWVEC (&abbrev_table->m_abbrev_obstack, struct attr_abbrev, cur_abbrev->num_attrs); -- 2.30.2