From b3d9ecf00ba759dbef2321968d9d66aa7572fed0 Mon Sep 17 00:00:00 2001 From: Jeffrey A Law Date: Mon, 2 Aug 1999 09:45:16 +0000 Subject: [PATCH] pa.c (legitimize_pic_address): Clarify comments. * pa.c (legitimize_pic_address): Clarify comments. Do not call the pic_load_label generator directly. * pa.md (pic_load_label): Clarify comments. Remove modes on operands. No longer a named pattern. From-SVN: r28401 --- gcc/ChangeLog | 7 +++++++ gcc/config/pa/pa.c | 11 ++++++++++- gcc/config/pa/pa.md | 8 ++++---- 3 files changed, 21 insertions(+), 5 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index d8aa90b5c8d..e213373257e 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +Mon Aug 2 03:38:33 1999 Jeffrey A Law (law@cygnus.com) + + * pa.c (legitimize_pic_address): Clarify comments. Do not call the + pic_load_label generator directly. + * pa.md (pic_load_label): Clarify comments. Remove modes on operands. + No longer a named pattern. + Mon Aug 2 09:38:10 1999 Nick Clifton * explow.c (force_reg): Call force_operand if X does not diff --git a/gcc/config/pa/pa.c b/gcc/config/pa/pa.c index 209976d473d..f5873f738df 100644 --- a/gcc/config/pa/pa.c +++ b/gcc/config/pa/pa.c @@ -628,7 +628,16 @@ legitimize_pic_address (orig, mode, reg) /* Labels need special handling. */ if (pic_label_operand (orig)) { - emit_insn (gen_pic_load_label (reg, orig)); + /* We do not want to go through the movXX expanders here since that + would create recursion. + + Nor do we really want to call a generator for a named pattern + since that requires multiple patterns if we want to support + multiple word sizes. + + So instead we just emit the raw set, which avoids the movXX + expanders completely. */ + emit_insn (gen_rtx_SET (VOIDmode, reg, orig)); current_function_uses_pic_offset_table = 1; return reg; } diff --git a/gcc/config/pa/pa.md b/gcc/config/pa/pa.md index e667d3cc122..c78692d7dc9 100644 --- a/gcc/config/pa/pa.md +++ b/gcc/config/pa/pa.md @@ -1568,12 +1568,12 @@ [(set_attr "type" "store") (set_attr "length" "4")]) -;; For pic +;; For loading the address of a label while generating PIC code. ;; Note since this pattern can be created at reload time (via movsi), all ;; the same rules for movsi apply here. (no new pseudos, no temporaries). -(define_insn "pic_load_label" - [(set (match_operand:SI 0 "register_operand" "=a") - (match_operand:SI 1 "pic_label_operand" ""))] +(define_insn "" + [(set (match_operand 0 "register_operand" "=a") + (match_operand 1 "pic_label_operand" ""))] "" "* { -- 2.30.2