From b3e3cb990125c71c1fd172588852bd92bcfb8904 Mon Sep 17 00:00:00 2001 From: Francisco Jerez Date: Sun, 17 Dec 2017 00:21:13 -0800 Subject: [PATCH] intel/fs: Initialize fs_visitor::grf_used on construction. This should shut up some Valgrind errors during pre-regalloc scheduling. The errors were harmless since they could only have led to the estimation of the bank conflict penalty of an instruction pre-regalloc, which is inaccurate at that point of the program compilation, but no less accurate than the intended "return 0" fall-back path. The scheduling pass is normally re-run after regalloc with a well-defined grf_used value and accurate bank conflict information. Fixes: acf98ff933d "intel/fs: Teach instruction scheduler about GRF bank conflict cycles." Reported-by: Eero Tamminen Reviewed-by: Ian Romanick --- src/intel/compiler/brw_fs_visitor.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/intel/compiler/brw_fs_visitor.cpp b/src/intel/compiler/brw_fs_visitor.cpp index 481d9c51e7a..7a5f6451f2b 100644 --- a/src/intel/compiler/brw_fs_visitor.cpp +++ b/src/intel/compiler/brw_fs_visitor.cpp @@ -898,6 +898,7 @@ fs_visitor::init() this->promoted_constants = 0, + this->grf_used = 0; this->spilled_any_registers = false; } -- 2.30.2