From b413232211bf7c7754095b017f27774d70646489 Mon Sep 17 00:00:00 2001 From: Alex Richardson Date: Sat, 28 Nov 2020 11:45:06 -0500 Subject: [PATCH] GDB: Fix detection of ELF support when configuring with -Werror=implicit-function-declaration I am getting I'm sorry, Dave, I can't do that. Symbol format `elf64-littleriscv' unknown. errors after updating from GDB 8.3 to 10. Bisecting showed that since commit 1ff6de031241 ("bfd, ld: add CTF section linking"), bfd.h depends on strncmp() being present, so configuring with -Werror=implicit-function-declaration results in the check for ELF support in BFD failing: .../gdb/gdb/../bfd/elf-bfd.h: In function 'bfd_section_is_ctf': .../gdb/gdb/../bfd/elf-bfd.h:3086:10: error: implicit declaration of function 'strncmp' [-Werror=implicit-function-declaration] return strncmp (name, ".ctf", 4) == 0 && (name[4] == 0 || name[4] == '.'); gdb/ChangeLog: * acincludde.m4 (GDB_AC_CHECK_BFD): Include string.h in the test program. Change-Id: Iec5e21d454c2a544c44d65e23cfde552c424c18e --- gdb/ChangeLog | 5 +++++ gdb/acinclude.m4 | 1 + gdb/configure | 2 ++ 3 files changed, 8 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index e9beaaba632..acffdefc8cf 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,8 @@ +2020-11-28 Alex Richardson + + * acincludde.m4 (GDB_AC_CHECK_BFD): Include string.h in the test + program. + 2020-11-27 Andrew Burgess * printcmd.c (skip_over_slash_fmt): Reorder code to ensure in_fmt diff --git a/gdb/acinclude.m4 b/gdb/acinclude.m4 index 64574e26314..68520d6d938 100644 --- a/gdb/acinclude.m4 +++ b/gdb/acinclude.m4 @@ -266,6 +266,7 @@ AC_DEFUN([GDB_AC_CHECK_BFD], [ [AC_LINK_IFELSE( [AC_LANG_PROGRAM( [#include + #include #include "bfd.h" #include "$4"], [return $3;] diff --git a/gdb/configure b/gdb/configure index a3e73b431c4..24e6fbc8fa7 100755 --- a/gdb/configure +++ b/gdb/configure @@ -17236,6 +17236,7 @@ else cat confdefs.h - <<_ACEOF >conftest.$ac_ext /* end confdefs.h. */ #include + #include #include "bfd.h" #include "elf-bfd.h" int @@ -17349,6 +17350,7 @@ else cat confdefs.h - <<_ACEOF >conftest.$ac_ext /* end confdefs.h. */ #include + #include #include "bfd.h" #include "mach-o.h" int -- 2.30.2