From b4a214207cd73272b7d22337834de79f96d7b48d Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Mon, 19 Aug 2019 12:41:18 -0700 Subject: [PATCH] pan/decode: Print "just right" count of texture pointers The other commented lines just add noise/entropy we don't want, and can in fact crash the trace due to asserts failing. Signed-off-by: Alyssa Rosenzweig --- src/panfrost/pandecode/decode.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/src/panfrost/pandecode/decode.c b/src/panfrost/pandecode/decode.c index 17f974ef33e..0af688f5729 100644 --- a/src/panfrost/pandecode/decode.c +++ b/src/panfrost/pandecode/decode.c @@ -1926,12 +1926,7 @@ pandecode_vertex_tiler_postfix_pre(const struct mali_vertex_tiler_postfix *p, int max_count = sizeof(t->payload) / sizeof(t->payload[0]); assert (bitmap_count <= max_count); - /* Dump more to be safe, but not _that_ much more */ - int safe_count = MIN2(bitmap_count * 2, max_count); - - for (int i = 0; i < safe_count; ++i) { - char *prefix = (i >= bitmap_count) ? "// " : ""; - + for (int i = 0; i < bitmap_count; ++i) { /* How we dump depends if this is a stride or a pointer */ if ((f.usage2 & MALI_TEX_MANUAL_STRIDE) && (i & 1)) { @@ -1940,10 +1935,10 @@ pandecode_vertex_tiler_postfix_pre(const struct mali_vertex_tiler_postfix *p, uint32_t clamped_stride = stride_set; int32_t stride = clamped_stride; assert(stride_set == clamped_stride); - pandecode_log("%s(mali_ptr) %d /* stride */, \n", prefix, stride); + pandecode_log("(mali_ptr) %d /* stride */, \n", stride); } else { char *a = pointer_as_memory_reference(t->payload[i]); - pandecode_log("%s%s, \n", prefix, a); + pandecode_log("%s, \n", a); free(a); } } -- 2.30.2